Repository navigation
chore: [SDK-5638] add extra IAM type buttons to demo apps - #79
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sherwinski
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds HTML, Full Bleed, Carousel, and Carousel Bleed IAM buttons to the demo apps (
demo,demo_pods) and lays out all 8 in a 2-column grid.Details
Motivation
Lets us test the extra IAM layouts from the demo app. Follows the shared spec update in OneSignal/sdk-shared#66 and matches iOS (OneSignal/OneSignal-iOS-SDK#1787).
Scope
iam_typevalues and test IDs (send_iam_{type}_button) are unchanged.SendIamSection: 8 buttons in a.iam-grid(2 columns,--space-card-gap). The 4 per-type handlers are replaced by oneonSendIam(type).HomeScreen.css: grid buttons usenowrap, 8px side padding, andclamp(11px, 3.4vw, 13px)font so labels fit on narrow screens. Other buttons are unchanged.demo_pods: drops the per-button IAM icons to matchdemoand the spec.Testing
Unit testing
None needed, demo UI only.
Manual testing
Ran
tsc,vp check, andvp buildin both demos. Checked the grid indemoon an Android 16 emulator.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code