Skip to content

chore: [SDK-5638] add extra IAM type buttons to demo apps - #79

Merged
fadi-george merged 1 commit into
mainfrom
fadi/sdk-5638
Oct 30, 2026
Merged

fadi-george merged 1 commit into
mainfrom
fadi/sdk-5638

Conversation

@fadi-george

@fadi-george fadi-george commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Adds HTML, Full Bleed, Carousel, and Carousel Bleed IAM buttons to the demo apps (demo, demo_pods) and lays out all 8 in a 2-column grid.

iOS Android

Details

Motivation

Lets us test the extra IAM layouts from the demo app. Follows the shared spec update in OneSignal/sdk-shared#66 and matches iOS (OneSignal/OneSignal-iOS-SDK#1787).

Scope

  • Labels are now Top, Bottom, Center, HTML, Full, Full Bleed, Carousel, Carousel Bleed (uppercased). Existing iam_type values and test IDs (send_iam_{type}_button) are unchanged.
  • SendIamSection: 8 buttons in a .iam-grid (2 columns, --space-card-gap). The 4 per-type handlers are replaced by one onSendIam(type).
  • HomeScreen.css: grid buttons use nowrap, 8px side padding, and clamp(11px, 3.4vw, 13px) font so labels fit on narrow screens. Other buttons are unchanged.
  • demo_pods: drops the per-button IAM icons to match demo and the spec.
  • Demo apps only. No SDK changes.

Testing

Unit testing

None needed, demo UI only.

Manual testing

Ran tsc, vp check, and vp build in both demos. Checked the grid in demo on an Android 16 emulator.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed (demo app UI only)
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george requested review from a team and abdulraqeeb33 October 30, 2026 18:43
@fadi-george
fadi-george merged commit c4f84a2 into main Oct 30, 2026
7 checks passed
@fadi-george
fadi-george deleted the fadi/sdk-5638 branch October 30, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants