Skip to content

Snehita - PR Review Team Admin Dashboard - Add the permission check to every PR Dashboard page #5787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snehitakandula wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Snehita - PR Review Team Admin Dashboard - Add the permission check to every PR Dashboard page #5787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 35 additions & 5 deletions src/routes.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,8 +1213,18 @@ export default (
/>
<ProtectedRoute path="/actual-cost-breakdown" component={ActualCostBreakdown} fallback />
<ProtectedRoute path="/prPromotionsPage" component={PRPromotionsPage} fallback />
<ProtectedRoute path="/pr-grading-screen" exact component={PRGradingScreen} />
<ProtectedRoute path="/pr-grading-test" exact component={PRGradingTest} />
<ProtectedRoute
path="/pr-grading-screen"
exact
component={PRGradingScreen}
routePermissions={RoutePermissions.prDashboard}
/>
<ProtectedRoute
path="/pr-grading-test"
exact
component={PRGradingTest}
routePermissions={RoutePermissions.prDashboard}
/>
{/* //temporary route for testing - delete after testing */}
<ProtectedRoute path="/" exact component={Dashboard} />
<ProtectedRoute
Expand All @@ -1227,12 +1237,14 @@ export default (
path="/pr-dashboard/promotion-eligibility"
exact
component={PromotionEligibility}
routePermissions={RoutePermissions.prDashboard}
/>
<ProtectedRoute path="/planned-costs" exact component={PlannedCostDonutChart} />
<ProtectedRoute
path="/pr-team-analytics/reviewers-stacked-bar-chart"
exact
component={ReviewersStackedBarChart}
routePermissions={RoutePermissions.prDashboard}
/>
<ProtectedRoute
path="/analytics/dashboard"
Expand All @@ -1245,6 +1257,7 @@ export default (
exact
component={PRReviewTeamAnalyticsDashboard}
fallback
routePermissions={RoutePermissions.prDashboard}
/>
<ProtectedRoute path="/analytics/popular-prs" exact component={PopularPRChart} fallback />
<ProtectedRoute
Expand All @@ -1262,15 +1275,26 @@ export default (
path="/pr-team-analytics/popular-prs"
exact
component={PRReviewTeamAnalytics}
routePermissions={RoutePermissions.prDashboard}
/>
<ProtectedRoute
path="/pr-grading-dashboard"
exact
component={PRGradingDashboard}
routePermissions={RoutePermissions.prDashboard}
/>
<ProtectedRoute path="/pr-dashboard/overview" exact component={PRDashboardOverview} />
<ProtectedRoute path="/pr-dashboard/analytics" exact component={PRReviewTeamAnalytics} />
<ProtectedRoute
path="/pr-dashboard/overview"
exact
component={PRDashboardOverview}
routePermissions={RoutePermissions.prDashboard}
/>
<ProtectedRoute
path="/pr-dashboard/analytics"
exact
component={PRReviewTeamAnalytics}
routePermissions={RoutePermissions.prDashboard}
/>
{/* <ProtectedRoute
path="/pr-dashboard/promotion-eligibility"
exact
Expand All @@ -1280,8 +1304,14 @@ export default (
path="/pr-dashboard/top-reviewed-prs"
exact
component={PRDashboardTopReviewedPRs}
routePermissions={RoutePermissions.prDashboard}
/>
<ProtectedRoute
path="/pr-dashboard/details"
exact
component={PRDashboardDetails}
routePermissions={RoutePermissions.prDashboard}
/>
<ProtectedRoute path="/pr-dashboard/details" exact component={PRDashboardDetails} />
<Route path="*" component={NotFoundPage} />
</Switch>
</>
Expand Down
Loading