Repository navigation
Snehita - PR Review Team Admin Dashboard - Add the permission check to every PR Dashboard page - #5787
Open
snehitakandula wants to merge 1 commit into
Open
snehitakandula wants to merge 1 commit into
snehitakandula wants to merge 1 commit into
Conversation
snehitakandula
added
the
High Priority - Please Review First
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements: 42. (PRIORITY HIGH) PR Review Team Admin Dashboard – Add the permission check to every PR Dashboard page.
Problem: in
routes.jsx, only/pr-dashboard, the first/pr-dashboard/analyticsroute and/pr-grading-dashboardchecked theprDashboardpermission. The other PR Dashboard pages loaded for any logged-in user.Related PRs:
Main changes explained:
Added
routePermissions={RoutePermissions.prDashboard}insrc/routes.jsxto all 10 routes listed in the task:/pr-dashboard/promotion-eligibility/pr-dashboard/top-reviewed-prs/pr-dashboard/details/pr-dashboard/overview/pr-dashboard/reviewers/pr-grading-screen/pr-grading-test/pr-team-analytics/popular-prs/pr-team-analytics/reviewers-stacked-bar-chart/pr-dashboard/analyticsrouteAll PR Dashboard routes now check the same permission (13 in total). No other files changed.
How to test:
npm install, thennpm run start:local(frontend) andnpm start(backend)Screenshots of changes:
Admin – page loads:
Note:
Frontend only. Backend APIs that already check permissions (for example Promotion Eligibility) are unchanged.