Skip to content

REPCA Documentation + Implementation - #422

Merged
nkoukpaizan merged 19 commits into
developfrom
lukel/repca-dev
Aug 6, 2026
Merged

REPCA Documentation + Implementation#422
nkoukpaizan merged 19 commits into
developfrom
lukel/repca-dev

Conversation

@lukelowry

@lukelowry lukelowry commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Implementation and documentation for the REPCA PhasorDynamics converter model.

Proposed changes

  • Added REPCA model implementation, documentation, and diagram.
  • Added REPCA JSON parsing and SystemModel assembly support.
  • Added focused PhasorDynamicsConverterRepcaTest unit coverage.
  • Added minimal REGCA pbranch/qbranch feedback exports for REPCA plant feedback.
  • Updated converter registration, input-format docs, and changelog.

Checklist

  • All tests pass (except known PE failure)
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR.

Further comments

None

@lukelowry lukelowry added this to the WECC Completion milestone Jun 1, 2026
@lukelowry
lukelowry force-pushed the lukel/repca-dev branch 4 times, most recently from 88836c3 to 79a1b2d Compare June 1, 2026 23:07
@lukelowry
lukelowry force-pushed the lukel/regca-impl branch 2 times, most recently from 2b91664 to 98b2935 Compare June 2, 2026 04:59
@lukelowry
lukelowry changed the base branch from lukel/regca-impl to develop June 8, 2026 07:15
@lukelowry
lukelowry marked this pull request as ready for review June 8, 2026 07:17
@lukelowry
lukelowry force-pushed the lukel/repca-dev branch 4 times, most recently from 8f6dd97 to 12defd2 Compare June 10, 2026 19:52
@lukelowry lukelowry mentioned this pull request Jun 23, 2026
7 tasks
@lukelowry
lukelowry force-pushed the lukel/repca-dev branch 2 times, most recently from d81be6c to 6198479 Compare June 25, 2026 21:18

@pelesh pelesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and ready to merge.

Reviews from @nkoukpaizan and @abirchfield would be helpful before merging.

Comment thread GridKit/Model/PhasorDynamics/Converter/REPCA/RepcaImpl.hpp Outdated
Comment thread GridKit/Model/PhasorDynamics/Controller/REPCA/Repca.hpp
Comment thread GridKit/Model/PhasorDynamics/Converter/REPCA/RepcaImpl.hpp Outdated
Comment thread GridKit/Model/PhasorDynamics/Converter/REPCA/RepcaImpl.hpp Outdated
@lukelowry

Copy link
Copy Markdown
Collaborator Author

@nkoukpaizan @abirchfield good to go!

@abirchfield abirchfield left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

@nkoukpaizan nkoukpaizan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me and tests pass. I would just ask for some additional alignment of the implementation, particularly in the tests.

Comment thread GridKit/Model/PhasorDynamics/Controller/REPCA/Repca.hpp Outdated
Comment thread GridKit/Model/PhasorDynamics/Controller/REPCA/RepcaImpl.hpp Outdated
Comment thread tests/UnitTests/PhasorDynamics/SystemSingleComponentTests.hpp Outdated
Comment thread GridKit/Model/PhasorDynamics/Controller/REPCA/Repca.hpp Outdated
Comment thread tests/UnitTests/PhasorDynamics/ControllerRepcaTests.hpp Outdated
Comment thread tests/UnitTests/PhasorDynamics/ControllerRepcaTests.hpp Outdated
Comment thread tests/UnitTests/PhasorDynamics/ControllerRepcaTests.hpp Outdated
Comment thread tests/UnitTests/PhasorDynamics/ControllerRepcaTests.hpp Outdated
@lukelowry

lukelowry commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator Author

Should be more aligned with HYGOV/REGCA/ESDC1A.

I learned a lot as I developed these, so I am not surprised that each one has diverged so much. Thank you for the detailed review I value the standardization as well.

and Rebased

@nkoukpaizan nkoukpaizan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. I'll merge when these are addressed and the branch is rebased.

Comment thread tests/UnitTests/PhasorDynamics/ControllerRepcaTests.hpp Outdated
Comment thread tests/UnitTests/PhasorDynamics/ControllerRepcaTests.hpp
Comment thread tests/UnitTests/PhasorDynamics/SystemSingleComponentTests.hpp Outdated
@lukelowry

Copy link
Copy Markdown
Collaborator Author

Rebased and addressed your final comments. I left one unresolved so we can make sure we are on the same page

@nkoukpaizan
nkoukpaizan merged commit 2699ec4 into develop Aug 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants