REPCA Documentation + Implementation - #422
Conversation
78d4d41 to
5f509c0
Compare
88836c3 to
79a1b2d
Compare
2b91664 to
98b2935
Compare
11a1fbe to
b0fc4cf
Compare
98b2935 to
96abffe
Compare
b0fc4cf to
530dc54
Compare
96abffe to
03b329f
Compare
530dc54 to
a27ffff
Compare
03b329f to
f4d4e70
Compare
a27ffff to
36170a5
Compare
36170a5 to
054a79f
Compare
f4d4e70 to
3be59eb
Compare
054a79f to
40bb369
Compare
8f6dd97 to
12defd2
Compare
12defd2 to
87719b5
Compare
d81be6c to
6198479
Compare
pelesh
left a comment
There was a problem hiding this comment.
This looks good to me and ready to merge.
Reviews from @nkoukpaizan and @abirchfield would be helpful before merging.
|
@nkoukpaizan @abirchfield good to go! |
nkoukpaizan
left a comment
There was a problem hiding this comment.
Overall looks good to me and tests pass. I would just ask for some additional alignment of the implementation, particularly in the tests.
65135e0 to
4342d4a
Compare
|
Should be more aligned with HYGOV/REGCA/ESDC1A. I learned a lot as I developed these, so I am not surprised that each one has diverged so much. Thank you for the detailed review I value the standardization as well. and Rebased |
nkoukpaizan
left a comment
There was a problem hiding this comment.
A few minor comments. I'll merge when these are addressed and the branch is rebased.
[skip ci]
8ddcbd6 to
a10a39e
Compare
|
Rebased and addressed your final comments. I left one unresolved so we can make sure we are on the same page |
Description
Implementation and documentation for the
REPCAPhasorDynamics converter model.Proposed changes
REPCAmodel implementation, documentation, and diagram.REPCAJSON parsing andSystemModelassembly support.PhasorDynamicsConverterRepcaTestunit coverage.pbranch/qbranchfeedback exports for REPCA plant feedback.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
None