Skip to content

REECB Documentation + Implementation - #421

Open
lukelowry wants to merge 16 commits into
developfrom
lukel/reecb-dev
Open

REECB Documentation + Implementation#421
lukelowry wants to merge 16 commits into
developfrom
lukel/reecb-dev

Conversation

@lukelowry

@lukelowry lukelowry commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Implementation and documentation for the REECB PhasorDynamics converter model.

Proposed changes

  • Added REECB model implementation, documentation, and diagram.
  • Added REECB JSON parsing and SystemModel assembly support.
  • Added focused PhasorDynamicsConverterReecbTest unit coverage.
  • Added minimal CommonMath compatibility needed for REECB dependency tracking/Jacobian paths.
  • Updated converter registration, input-format docs, and changelog.

Checklist

  • All tests pass (except known PE failure)
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR.

Further comments

Intended to be merged after #436

@lukelowry lukelowry added this to the WECC Completion milestone Jun 1, 2026
@lukelowry
lukelowry force-pushed the lukel/reecb-dev branch 6 times, most recently from bec889f to f821b35 Compare June 1, 2026 23:07
@lukelowry
lukelowry force-pushed the lukel/regca-impl branch 2 times, most recently from 2b91664 to 98b2935 Compare June 2, 2026 04:59
@lukelowry
lukelowry changed the base branch from lukel/regca-impl to develop June 8, 2026 07:15
@lukelowry
lukelowry marked this pull request as ready for review June 8, 2026 07:16
@lukelowry
lukelowry force-pushed the lukel/reecb-dev branch 4 times, most recently from 6c86d9d to 7a4fdbc Compare June 10, 2026 19:52
@lukelowry
lukelowry force-pushed the lukel/reecb-dev branch 5 times, most recently from 70faff0 to aebd086 Compare August 6, 2026 20:15
nkoukpaizan
nkoukpaizan approved these changes Aug 6, 2026
View reviewed changes

@nkoukpaizan nkoukpaizan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

A few minor comments. I can't load the diff online, but I think the Jacobian tests will need to be updated to avoid handling missing entries and zeros differently (as discussed in #422.

Comment thread tests/IntegrationTests/PhasorDynamics/PDIntegrationTests.hpp Outdated
Comment thread tests/IntegrationTests/PhasorDynamics/PDIntegrationTests.hpp

auto& bus = data.bus.emplace_back();
bus.bus_id = kReecbBusId;
bus.bus_type = BusDataT::BusType::SLACK;

@nkoukpaizan nkoukpaizan Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[WARNING] A component has returned a nullptr Jacobian.
Is this the desired behavior, or can we use BusType::DEFAULT here.

Comment thread tests/UnitTests/PhasorDynamics/SystemSingleComponentTests.hpp Outdated
Comment thread GridKit/Model/PhasorDynamics/Controller/REECB/ReecbImpl.hpp
@lukelowry

lukelowry commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Will rebase and address these issues. will be done soon. this is super super helpful for validation thank you. we are on a roll

nkoukpaizan
nkoukpaizan reviewed Aug 7, 2026
View reviewed changes

@nkoukpaizan nkoukpaizan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something happened in the past few commits. I'm now getting extremely long build times on one of my testing backends.

Flagging one regression I've seen, though that would not be the cause of compilation issues.

Comment thread GridKit/Model/PhasorDynamics/Controller/REECB/ReecbImpl.hpp Outdated
pelesh
pelesh approved these changes Aug 7, 2026
View reviewed changes

@pelesh pelesh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Some nitpicking comments below.

Comment thread GridKit/Model/PhasorDynamics/SystemModelImpl.hpp
Comment thread GridKit/Model/PhasorDynamics/Controller/REECB/Reecb.hpp Outdated
Comment thread GridKit/Model/PhasorDynamics/Controller/REECB/ReecbImpl.hpp Outdated
@pelesh pelesh mentioned this pull request Aug 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkoukpaizan nkoukpaizan nkoukpaizan approved these changes
@pelesh pelesh pelesh approved these changes
@abirchfield abirchfield Awaiting requested review from abirchfield

Assignees

@lukelowry lukelowry

Labels

new model

Projects

None yet

Milestone

WECC Completion

Development

Successfully merging this pull request may close these issues.

3 participants

@lukelowry @pelesh @nkoukpaizan