Skip to content

GAST-PTI Documentation + Implementation - #420

Open
lukelowry wants to merge 13 commits into
developfrom
lukel/gastpti-dev
Open

GAST-PTI Documentation + Implementation#420
lukelowry wants to merge 13 commits into
developfrom
lukel/gastpti-dev

Conversation

@lukelowry

@lukelowry lukelowry commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Implementation and documentation for the GASTPTI PhasorDynamics governor model.

Proposed changes

  • Added GASTPTI model implementation, documentation, and diagram.
  • Added GASTPTI JSON parsing and SystemModel assembly support.
  • Added focused PhasorDynamicsGovernorGastPtiTest unit coverage.
  • Updated governor registration, input-format docs, and changelog.

Checklist

  • All tests pass (except known PE failure)
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR.

Further comments

The initialization of Pmech in relation to the machine is not ideal and still relies on the machine being initialized first. It makes reading the implementation confusing, in my opinion. I am partial to changing how we initialize models like this (see #405)

@lukelowry
lukelowry force-pushed the lukel/gastpti-dev branch 3 times, most recently from 2ed0a56 to be22547 Compare June 1, 2026 05:16
@lukelowry
lukelowry requested review from abirchfield and pelesh June 1, 2026 05:20
@lukelowry
lukelowry marked this pull request as ready for review June 1, 2026 05:21
@lukelowry lukelowry added this to the WECC Completion milestone Jun 1, 2026
@lukelowry
lukelowry force-pushed the lukel/gastpti-dev branch 6 times, most recently from 34f2b24 to 8c3f488 Compare June 5, 2026 19:44
@lukelowry
lukelowry force-pushed the lukel/gastpti-dev branch 3 times, most recently from 215ae91 to cef55e1 Compare June 10, 2026 18:56
@lukelowry
lukelowry force-pushed the lukel/gastpti-dev branch from cef55e1 to cb8ce73 Compare June 22, 2026 16:34
@lukelowry lukelowry mentioned this pull request Jun 23, 2026
7 tasks
@lukelowry
lukelowry force-pushed the lukel/gastpti-dev branch 3 times, most recently from 8384e1d to ad9c411 Compare July 1, 2026 06:12
@lukelowry
lukelowry force-pushed the lukel/gastpti-dev branch 2 times, most recently from 9b39a22 to 26e82e8 Compare July 9, 2026 16:09
@lukelowry
lukelowry force-pushed the lukel/gastpti-dev branch 5 times, most recently from 86b7985 to 1ef1115 Compare July 17, 2026 21:58
@lukelowry
lukelowry force-pushed the lukel/gastpti-dev branch 4 times, most recently from 8d11331 to 465fefb Compare July 24, 2026 23:17
@pelesh
pelesh requested a review from nkoukpaizan August 3, 2026 15:07
@lukelowry
lukelowry force-pushed the lukel/gastpti-dev branch 4 times, most recently from 3593915 to 1872567 Compare August 6, 2026 21:48

@nkoukpaizan nkoukpaizan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but otherwise looks good to me. I'll wait for other reviews and take another look before approving.

Comment thread GridKit/Model/PhasorDynamics/Governor/GASTPTI/README.md
Comment thread tests/UnitTests/PhasorDynamics/ComponentConnectionTests.hpp
Comment thread GridKit/Model/PhasorDynamics/Governor/GASTPTI/GastPtiImpl.hpp Outdated
@lukelowry

Copy link
Copy Markdown
Collaborator Author

Rebased and did some other consistency changes to match the merged models. Pending @pelesh @abirchfield

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants