GAST-PTI Documentation + Implementation - #420
Open
lukelowry wants to merge 13 commits into
Open
Conversation
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
3 times, most recently
from
June 1, 2026 05:16
2ed0a56 to
be22547
Compare
lukelowry
marked this pull request as ready for review
June 1, 2026 05:21
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
6 times, most recently
from
June 5, 2026 19:44
34f2b24 to
8c3f488
Compare
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
3 times, most recently
from
June 10, 2026 18:56
215ae91 to
cef55e1
Compare
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
from
June 22, 2026 16:34
cef55e1 to
cb8ce73
Compare
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
3 times, most recently
from
July 1, 2026 06:12
8384e1d to
ad9c411
Compare
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
2 times, most recently
from
July 9, 2026 16:09
9b39a22 to
26e82e8
Compare
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
5 times, most recently
from
July 17, 2026 21:58
86b7985 to
1ef1115
Compare
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
4 times, most recently
from
July 24, 2026 23:17
8d11331 to
465fefb
Compare
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
from
August 2, 2026 01:10
d88b16d to
099a9cd
Compare
7 tasks
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
4 times, most recently
from
August 6, 2026 21:48
3593915 to
1872567
Compare
nkoukpaizan
reviewed
Aug 6, 2026
nkoukpaizan
left a comment
Collaborator
There was a problem hiding this comment.
A few minor comments, but otherwise looks good to me. I'll wait for other reviews and take another look before approving.
[skip ci]
…ed for validation
lukelowry
force-pushed
the
lukel/gastpti-dev
branch
from
August 7, 2026 05:54
f954045 to
ed2ba3f
Compare
Collaborator
Author
|
Rebased and did some other consistency changes to match the merged models. Pending @pelesh @abirchfield |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation and documentation for the
GASTPTIPhasorDynamics governor model.Proposed changes
GASTPTImodel implementation, documentation, and diagram.GASTPTIJSON parsing andSystemModelassembly support.PhasorDynamicsGovernorGastPtiTestunit coverage.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
The initialization of
Pmechin relation to the machine is not ideal and still relies on the machine being initialized first. It makes reading the implementation confusing, in my opinion. I am partial to changing how we initialize models like this (see #405)