ESDC1A Documentation + Implementation - #424
Merged
Merged
Conversation
lukelowry
marked this pull request as ready for review
June 1, 2026 03:23
lukelowry
force-pushed
the
lukel/esdc1a-dev
branch
3 times, most recently
from
June 5, 2026 18:40
9000b94 to
7867706
Compare
lukelowry
force-pushed
the
lukel/esdc1a-dev
branch
3 times, most recently
from
June 10, 2026 18:56
9119520 to
04010fa
Compare
lukelowry
force-pushed
the
lukel/esdc1a-dev
branch
from
June 22, 2026 16:34
04010fa to
3fce76c
Compare
lukelowry
force-pushed
the
lukel/esdc1a-dev
branch
4 times, most recently
from
June 26, 2026 14:18
379e156 to
58d9dcf
Compare
Collaborator
Author
|
Rebased and cleaned. Issue discussed in PR body is still an issue but out of the scope of this PR |
lukelowry
force-pushed
the
lukel/esdc1a-dev
branch
3 times, most recently
from
July 2, 2026 21:54
0000eca to
11d0fd8
Compare
lukelowry
force-pushed
the
lukel/esdc1a-dev
branch
3 times, most recently
from
July 15, 2026 04:26
523b445 to
520fde9
Compare
lukelowry
force-pushed
the
lukel/esdc1a-dev
branch
2 times, most recently
from
July 17, 2026 03:11
8cd4a36 to
3f9e364
Compare
Collaborator
Author
|
The model is ready @abirchfield @nkoukpaizan |
abirchfield
approved these changes
Aug 4, 2026
abirchfield
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed and discussed in person. Ready to merge.
[skip ci]
lukelowry
force-pushed
the
lukel/esdc1a-dev
branch
from
August 4, 2026 19:58
9ee9859 to
f68eb83
Compare
Collaborator
Author
|
Rebased! |
nkoukpaizan
approved these changes
Aug 4, 2026
nkoukpaizan
left a comment
Collaborator
There was a problem hiding this comment.
Good enough to merge. Thanks for the hard work!
Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
Collaborator
Author
|
Good to go. I'll begin making the other open PR models align with this and REGCA. Not opposed if you want to merge #521 after this |
pelesh
approved these changes
Aug 4, 2026
andrewxu319
pushed a commit
that referenced
this pull request
Aug 6, 2026
* Docs and Implementation for ESDC1A * revised and improved model * minor cleaning * consistant use of enums/ordering/doxygen * Lower antiwindup limit (design similar to HYGOV) * saturation parameter validation * ret convention and zero comparison * success test oeprator accumulation * system integratino and basic assembly tests * esdc1a final touches * Replace ampersand again * TestOutcome consistancy usage * implementation zero comparisons * Move tests and zero comparison * test tolerance clearer * Update GridKit/Model/PhasorDynamics/Exciter/ESDC1A/Esdc1aImpl.hpp Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com> * Move connection tests to unit --------- Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com> Co-authored-by: lukelowry <lukelowry@users.noreply.github.com>
andrewxu319
pushed a commit
that referenced
this pull request
Aug 6, 2026
* Docs and Implementation for ESDC1A * revised and improved model * minor cleaning * consistant use of enums/ordering/doxygen * Lower antiwindup limit (design similar to HYGOV) * saturation parameter validation * ret convention and zero comparison * success test oeprator accumulation * system integratino and basic assembly tests * esdc1a final touches * Replace ampersand again * TestOutcome consistancy usage * implementation zero comparisons * Move tests and zero comparison * test tolerance clearer * Update GridKit/Model/PhasorDynamics/Exciter/ESDC1A/Esdc1aImpl.hpp Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com> * Move connection tests to unit --------- Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com> Co-authored-by: lukelowry <lukelowry@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation and documentation for the
ESDC1APhasorDynamics exciter model.Proposed changes
ESDC1Amodel implementation, documentation, and diagram.ESDC1AJSON parsing andSystemModelassembly support.PhasorDynamicsExciterEsdc1aTestunit coverage.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments (A)
@nkoukpaizan, I keep running into an issue with Enzyme for Exciter models in the control voltage effective input algebraic equation:
Enzyme fails if that is an inline expression. Sparsity issue. I am not sure if this is intentional, but I finally found a reliable way to circumvent the issue within the model implementation (the code above).
Further comments (B)
@pelesh @abirchfield @alexander-novo
Out of PR scope, but there is a modeling issue that I'd like to raise here:
GENROU) that we do not currently support:IEEET1, locally computeBus, conditionally included based on consumption (otherwise we could introduce unused nonlinear algebraic equations incessantly!). Same forPlease let me know if I should open distinct issues for these. They are front of mind as I implemented this so I am leaving here for now.