HYGOV Documentation + Implementation - #419
Conversation
90efc5e to
42ec335
Compare
f319b08 to
44ca9b3
Compare
810972f to
851c465
Compare
851c465 to
f7b5020
Compare
d368563 to
e045835
Compare
|
This model has been rebased and is now up to date and consistant with the other docs and implementations |
70e8e12 to
d90e2f2
Compare
009c82c to
7091725
Compare
df68cb5 to
0d45022
Compare
nkoukpaizan
left a comment
There was a problem hiding this comment.
This is close to being ready to merge. A few things to address in addition to the suggested comments:
I'm seeing a couple of test failures on MacOS with GCC. Tests pass with LLVM.
Truncated output:
39: flat-segment plateau gate mismatch: 0.4990295868366958 != 0.4990297247065128
39: --- FAIL: Test turbineDynamics
44: IP mismatch: 0.22000000000000033 != 0.22
44: --- FAIL: Test residualEquations
The following tests FAILED:
39 - PhasorDynamicsGovernorHygovTest (Failed)
44 - PhasorDynamicsConverterRegcaTest (Failed)
|
Okay, much cleaner now and consistant with the other model. thank you. And I fixed the broken test I believe, I wrote a better test. |
[skip ci]
122a553 to
7ebf2e1
Compare
abirchfield
left a comment
There was a problem hiding this comment.
Thanks Luke. This will be good to get a hydro governor into our cases, as these have different control characteristics than the other ones. The backlash approach seems correct.
|
@nkoukpaizan All ready. All 4 remaining models are rebased and standardized to the best of my . This one is the best of the group |
Description
Implementation and documentation for the
HYGOVPhasorDynamics governor model.Proposed changes
HYGOVmodel implementation, documentation, and diagram.HYGOVJSON parsing andSystemModelassembly support.PhasorDynamicsGovernorHygovTestunit coverage.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
None