Skip to content

HYGOV Documentation + Implementation - #419

Merged
nkoukpaizan merged 17 commits into
developfrom
lukel/hygov-dev
Aug 6, 2026
Merged

HYGOV Documentation + Implementation#419
nkoukpaizan merged 17 commits into
developfrom
lukel/hygov-dev

Conversation

@lukelowry

@lukelowry lukelowry commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Description

Implementation and documentation for the HYGOV PhasorDynamics governor model.

Proposed changes

  • Added HYGOV model implementation, documentation, and diagram.
  • Added HYGOV JSON parsing and SystemModel assembly support.
  • Added focused PhasorDynamicsGovernorHygovTest unit coverage.
  • Included source-default curve behavior for zeroed source curve data.
  • Updated governor registration, input-format docs, and changelog.

Checklist

  • All tests pass (except known PE failure)
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR.

Further comments

None

@lukelowry lukelowry added this to the WECC Completion milestone Jun 1, 2026
@lukelowry
lukelowry force-pushed the lukel/hygov-dev branch 8 times, most recently from 90efc5e to 42ec335 Compare June 6, 2026 09:48
@lukelowry
lukelowry force-pushed the lukel/hygov-dev branch 2 times, most recently from f319b08 to 44ca9b3 Compare June 8, 2026 07:13
@lukelowry
lukelowry marked this pull request as ready for review June 8, 2026 07:14
@lukelowry
lukelowry force-pushed the lukel/hygov-dev branch 4 times, most recently from 810972f to 851c465 Compare June 10, 2026 19:52
@lukelowry lukelowry mentioned this pull request Jun 23, 2026
7 tasks
@lukelowry
lukelowry force-pushed the lukel/hygov-dev branch 3 times, most recently from d368563 to e045835 Compare June 26, 2026 02:12
@lukelowry

Copy link
Copy Markdown
Collaborator Author

This model has been rebased and is now up to date and consistant with the other docs and implementations

@lukelowry
lukelowry force-pushed the lukel/hygov-dev branch 3 times, most recently from 70e8e12 to d90e2f2 Compare July 2, 2026 21:08
@lukelowry
lukelowry force-pushed the lukel/hygov-dev branch 3 times, most recently from 009c82c to 7091725 Compare July 15, 2026 04:26
Comment thread GridKit/Model/PhasorDynamics/Governor/HYGOV/HygovImpl.hpp Outdated
@lukelowry
lukelowry force-pushed the lukel/hygov-dev branch 2 times, most recently from df68cb5 to 0d45022 Compare August 5, 2026 00:36

@nkoukpaizan nkoukpaizan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to being ready to merge. A few things to address in addition to the suggested comments:

I'm seeing a couple of test failures on MacOS with GCC. Tests pass with LLVM.

Truncated output:

39: flat-segment plateau gate mismatch: 0.4990295868366958 != 0.4990297247065128
39: --- FAIL: Test turbineDynamics

44: IP mismatch: 0.22000000000000033 != 0.22
44: --- FAIL: Test residualEquations

The following tests FAILED:
	 39 - PhasorDynamicsGovernorHygovTest (Failed)
	 44 - PhasorDynamicsConverterRegcaTest (Failed)

Comment thread tests/UnitTests/PhasorDynamics/GovernorHygovTests.hpp Outdated
Comment thread tests/UnitTests/PhasorDynamics/GovernorHygovTests.hpp Outdated
@lukelowry

lukelowry commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator Author

Okay, much cleaner now and consistant with the other model. thank you. And I fixed the broken test I believe, I wrote a better test.

@abirchfield abirchfield left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Luke. This will be good to get a hydro governor into our cases, as these have different control characteristics than the other ones. The backlash approach seems correct.

@lukelowry

Copy link
Copy Markdown
Collaborator Author

@nkoukpaizan All ready. All 4 remaining models are rebased and standardized to the best of my . This one is the best of the group

@nkoukpaizan
nkoukpaizan merged commit 41f9949 into develop Aug 6, 2026
3 of 5 checks passed
@lukelowry
lukelowry deleted the lukel/hygov-dev branch August 6, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants