Repository navigation
test(cutile): skip FP8 execution on unsupported targets - #1683
Merged
Merged
Conversation
Signed-off-by: Melih Elibol <1884921+elibol@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
20 tasks
elibol
marked this pull request as ready for review
October 30, 2026 22:09
elibol
added a commit
to elibol/cuda-rust
that referenced
this pull request
Oct 30, 2026
Merge main through NVIDIA#1541, NVIDIA#1683 and NVIDIA#1634. Resolve workflow conflicts using the accepted NVIDIA#1580 copy-pr-bot triggers. Signed-off-by: Melih Elibol <1884921+elibol@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two FP8 execution tests in
dtype_float_opscurrently attempt to compile FP8 kernels on targets below sm_90, where the compiler correctly rejects them. Check the existingFeature::Fp8capability before allocating either tensor, so unsupported targets print the standard skip diagnostic while supported targets still run creation, conversion, and numerical checks.Toolkit discovery failures and JIT/execution failures remain test failures. The four other float tests are unchanged.
Validation:
cargo test -p cutile --features experimental-tune --test dtype_float_ops -- --nocapture: all six tests pass on RTX 5090 / CUDA 13.3, including both FP8 execution paths.cargo fmt --all -- --checkandgit diff --check: pass.scripts/run_all.sh: CPU/assembler and GPU suites pass; 27 examples pass with one expected toolkit-dependent skip; all eight benchmarks pass.Target release: cuTile Rust v0.5.0.