[None][infra] Waive 2 failed cases for main in pre-merge 52091 - #17349
[None][infra] Waive 2 failed cases for main in pre-merge 52091#17349trtllm-agent wants to merge 1 commit into
Conversation
Bug(s): 6567731 Requested by: @shuyixiong Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe integration waiver list adds skip entries for two PyTorch accuracy tests. Both entries reference NVBUG 6567731. ChangesPyTorch accuracy test waivers
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot skip --comment "Waive tests" |
|
PR_Github #64265 [ skip ] triggered by Bot. Commit: |
|
PR_Github #64265 [ skip ] completed with state |
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
Entries are well-formed, correctly sorted, and not duplicates of existing waives for these tests. One scoping question inline. Also worth noting the failure signature here isn't specific to these two tests — if it recurs, chasing the underlying infra issue will be cheaper than accumulating per-test waives.
| accuracy/test_llm_api_pytorch.py::TestDeepSeekV4Flash::test_auto_dtype SKIP (https://nvbugs/6561677) | ||
| accuracy/test_llm_api_pytorch.py::TestGLM52::test_nvfp4[tp_size=8-ep_size=8] SKIP (https://nvbugs/6507108) | ||
| accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_eagle3_guided_decoding_4gpus[one_model] SKIP (https://nvbugs/5596343) | ||
| accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_w4_1gpu[v1_kv_cache-True-True-cutlass-auto] SKIP (https://nvbugs/6567731) |
There was a problem hiding this comment.
Both entries are unqualified, so they skip on every platform, but the reported failures came from a single stage (GB300-PyTorch-1) and the failure mode is a session/worker bootstrap timeout rather than anything specific to GPT-OSS w4 or Qwen3 fp8 block scales. Consider a full:GB300/-prefixed waive (as done elsewhere in this file, e.g. lines 259, 290) so these keep running on other GPUs where they pass.
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @shuyixiong)
Target branch:
mainBug(s): 6567731
Waive entries added
Already waived (skipped)
accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_w4_1gpu[v2_kv_cache-True-True-cutlass-auto]This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
tests/integration/test_lists/waives.txt.QA Engineer Review
test-db/orqa/files were modified.TestGPTOSS::test_w4_1gpu[v1_kv_cache-True-True-cutlass-auto]TestQwen3_8B::test_fp8_block_scales[latency]