[https://nvbugs/6517844][test] Unwaive DeepSeek V3 Lite RTX Pro 6000D test - #17364
[https://nvbugs/6517844][test] Unwaive DeepSeek V3 Lite RTX Pro 6000D test#17364nv-lschneider wants to merge 1 commit into
Conversation
|
/bot run --stage-list "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-*" |
Signed-off-by: Ludwig Schneider <lschneider@nvidia.com>
cdcd367 to
7f642ef
Compare
WalkthroughRemoved the waiver for Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #64343 [ run ] triggered by Bot. Commit: |
|
PR_Github #64343 [ run ] completed with state
|
|
/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-*" |
|
PR_Github #64356 [ run ] triggered by Bot. Commit: |
|
PR_Github #64356 [ run ] completed with state
|
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
Matches the bug — the fix in #16956 landed and the bug asks for exactly this unwaive.
Two CI notes before merging:
- The test only runs post-merge, so a plain
/bot runwon't cover it. Run/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2"— it failed in both stages, not just -2. - The removed line has no GPU prefix, so it was skipping this parametrization on B200/B300/GB300 too (
l0_dgx_b200.yml,l0_dgx_b300.yml,l0_gb300_multi_gpus.yml). Worth adding those multi-GPU post-merge stages as well so the re-enable doesn't turn into a post-merge surprise on a platform nobody checked.
|
/bot run --extra-stage "RTXPro6000D-4_GPUs-PyTorch-Post-Merge-1,RTXPro6000D-4_GPUs-PyTorch-Post-Merge-2,DGX_B300-4_GPUs-PyTorch-Post-Merge-1,DGX_B300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GB300-4_GPUs-PyTorch-Post-Merge-3" |
|
Thanks for the review, I am broadening the CI coverage to get full coverage. |
FIx merged with #16956
This just unwaives the test.
Dev Engineer Review
TestDeepSeekV3Lite::test_bfloat16_4gpuswithep4,mtp_nextn=2, andtorch_compile=False.tests/integration/test_lists/waives.txt.QA Engineer Review
tests/integration/test_lists/waives.txt.TestDeepSeekV3Lite::test_bfloat16_4gpus.RTXPro6000D-4_GPUs-PyTorch-Post-Merge-*bot test stages.