[None][test] Waive 3 failed cases for main in QA CI - #17329
Conversation
Bug(s): 6474894, 6546909, 6562582, 6563551 Requested by: qa@nvidia.com Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "skip failed tests" |
WalkthroughThree skipped integration-test entries were added to ChangesIntegration test waivers
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 258: Add a repository-supported NVIDIA copyright header including 2026 to
tests/integration/test_lists/waives.txt without introducing a raw non-empty line
that verify_waive_list treats as a waiver; if no supported format exists, update
scripts/check_test_list.py::verify_waive_list and its parser to recognize and
skip the header while preserving waiver validation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1546557c-342f-4873-805f-36f5f499a14e
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #64163 [ skip ] triggered by Bot. Commit: |
|
PR_Github #64163 [ skip ] completed with state |
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
All three test IDs resolve to real tests and param IDs on disk, no duplicates, sorted correctly — mergeable.
One thing to check before merge: the entry citing https://nvbugs/6546909 — that bug was filed against a different test/parameterization on a different GPU than the H20 4-GPU FLASHINFER case being waived here. The failures may share a root cause, but as filed the bug won't be re-verified against this config, so the waive risks being orphaned (or removed prematurely) when the bug closes. Worth adding this case to that bug or filing one that covers it.
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by qa@nvidia.com)
Target branch:
mainBug(s): 6474894, 6546909, 6562582, 6563551
Waive entries added
Already waived (skipped)
full:B200/accuracy/test_llm_api_pytorch.py::TestNemotronV3Ultra::test_nvfp4_4gpus_block_reuse[TEP4]This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
tests/integration/test_lists/waives.txt.QA Engineer Review
tests/integration/test_lists/waives.txt.