Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 52038 - #17338

Merged
longlee0622 merged 2 commits into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260806-035240
Aug 6, 2026
Merged

[None][infra] Waive 1 failed cases for main in pre-merge 52038#17338
longlee0622 merged 2 commits into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260806-035240

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @longlee0622)
Target branch: main
Bug(s): 6566777

Waive entry added

perf/test_perf_sanity.py::test_e2e[disagg_upload-e2e-gb300_glm-5-fp4_8k1k_con1024_ctx1_dep2_gen1_dep8_eplb256_mtp1_ccb-NIXL] SKIP (https://nvbugs/6566777)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • Added three waiver entries in tests/integration/test_lists/waives.txt.
  • Waived the context and generation cache_transceiver_precheck cases.
  • Waived the GB300 GLM-5 disaggregated performance sanity case.
  • Each entry references an NVBug issue.
  • The change is limited to the intended waiver scope.
  • No public API or code changes were introduced.

QA Engineer Review

  • No test-db/ or qa/ files were modified.
  • Added three entries to tests/integration/test_lists/waives.txt.
  • Removed no entries.
  • CBTS coverage data is unavailable.
  • Verdict: needs follow-up.

Bug(s): 6550130, 6566777
Requested by: @longlee0622

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

A skipped GB300 GLM-5 disaggregated performance sanity test was added to the integration test waiver list. The entry references NVBug 6566777.

Changes

Integration test waiver

Layer / File(s) Summary
Add GB300 GLM-5 waiver
tests/integration/test_lists/waives.txt
Adds a skipped GB300 GLM-5 disaggregated performance sanity test linked to NVBug 6566777.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: brnguyen2, bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies an infrastructure change that waives a failed pre-merge case for main.
Description check ✅ Passed The description identifies the target branch, bug, exact waived test, and skip action, but omits the repository template headings and checklist.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 105-106: Add the repository-standard NVIDIA copyright header at
the beginning of tests/integration/test_lists/waives.txt, using 2026 as the
latest meaningful modification year, while preserving the existing waiver
entries unchanged.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d8f7cdf5-6824-42eb-b5a2-be344bb3113e

📥 Commits

Reviewing files that changed from the base of the PR and between be9b16c and 54599f6.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt Outdated
@longlee0622
longlee0622 enabled auto-merge (squash) August 6, 2026 03:58
Comment thread tests/integration/test_lists/waives.txt Outdated
As per @chuangz0 , waive these tests directly will fail CI at check test list stage. Recall the waive.

Signed-off-by: Jonas Li <6110159+longlee0622@users.noreply.github.com>
@longlee0622 longlee0622 changed the title [None][infra] Waive 3 failed cases for main in pre-merge 52038 [None][infra] Waive 1 failed cases for main in pre-merge 52038 Aug 6, 2026
@longlee0622

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive known failing test"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64219 [ skip ] triggered by Bot. Commit: 6546929 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64219 [ skip ] completed with state SUCCESS. Commit: 6546929
Skipping testing for commit 6546929

Link to invocation

@longlee0622
longlee0622 merged commit 80b9301 into NVIDIA:main Aug 6, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants