Skip to content

fix(ci): retain compatibility review SDK error messages #5292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elezar merged 4 commits into from
Nov 5, 2026
+2 −1
Merged

fix(ci): retain compatibility review SDK error messages #5292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28b6470
fix(ci): expose compatibility review failure diagnostics
matthewgrossman Nov 5, 2026
f035b71
fix(ci): simplify compatibility error reporting
matthewgrossman Nov 5, 2026
ebea7e1
fix(ci): pass through SDK errors without filtering
matthewgrossman Nov 5, 2026
64a1423
chore(ci): remove compatibility error test file
matthewgrossman Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CI.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ Each run retains `report.json` and `report.md` for 90 days in
`compatibility-review-run-<run-id>-attempt-<attempt>`. The report records both
revisions, the train, tool/model metadata, coverage gaps, and actionable
findings. Raw agent transcripts and PR discussions are not published.
SDK failures retain the exception message in the report.
The qualification summary links this separate advisory evidence without waiting
for it; compatibility
review remains missing from the blocking RFC profile during this rollout.
Expand Down
2 changes: 1 addition & 1 deletion tasks/scripts/codex_compatibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ async def invoke_codex(context: dict, directory: Path) -> dict:
result = await thread.run(prompt, output_schema=schema)
except (openai_codex.CodexError, RuntimeError, ValueError) as error:
raise ValueError(
f"Codex SDK review failed ({type(error).__name__}); no assessment is available."
f"Codex SDK review failed ({type(error).__name__}): {error}; no assessment is available."
) from None
finally:
await codex.close()
Expand Down
Loading