Skip to content

fix(ci): retain compatibility review SDK error messages - #5292

Merged
elezar merged 4 commits into
mainfrom
fix/compatibility-review-diagnostics/matthewgrossman
Nov 5, 2026
Merged

elezar merged 4 commits into
mainfrom
fix/compatibility-review-diagnostics/matthewgrossman

Conversation

@matthewgrossman

@matthewgrossman matthewgrossman commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Summary

Include the SDK exception message in the existing compatibility report instead of discarding it.

Related Issue

CI failure-diagnostics fix; no separate issue. For example, #5291's compatibility review retained only Codex SDK review failed (RuntimeError).

Changes

  • Preserve the exception message in the existing error handler and report.
  • Keep the current SDK call, advisory behavior, exit status, and report format. No streaming collector or diagnostics framework.
  • Document the retained message.

Release Notes

Testing

  • Ruff lint/format, ty, Markdown lint, and git diff --check.
  • Live inference execution; the workflow credential is available only in CI.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
@matthewgrossman matthewgrossman changed the title fix(ci): expose compatibility review failure diagnostics fix(ci): retain compatibility review SDK error messages Nov 5, 2026
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
@elezar
elezar added this pull request to the merge queue Nov 5, 2026
Merged via the queue into main with commit c9c9143 Nov 5, 2026
84 of 85 checks passed
@elezar
elezar deleted the fix/compatibility-review-diagnostics/matthewgrossman branch November 5, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants