Repository navigation
test(conformance): prompt delete when the workload is slow to handle TERM - #5291
Merged
Merged
Conversation
3 of 4 tasks
matthewgrossman
commented
Nov 5, 2026
elezar
reviewed
Nov 5, 2026
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
elezar
force-pushed
the
test/5290-running-delete-deadline/matthewgrossman
branch
from
November 6, 2026 12:38
fbcbfe9 to
3974537
Compare
elezar
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Many workloads do not exit immediately on TERM, for example while they run cleanup handlers. Add an all-driver conformance test requiring that deleting such a running sandbox still completes promptly, rather than waiting out the runtime's termination grace period.
Related Issue
Closes #5290.
Related to #5285, which remains open for stronger signal-processing and runtime-termination evidence. #5290 has no acceptance label; the author has verified ADMIN access.
Changes
TERM_HANDLING_DELAY(3 s) before exiting, and synchronize on a readiness marker written after the trap is installed.DELETE_DEADLINE(10 s) that starts before deletion.Why these values:
The assertion is prompt deletion, not graceful workload exit or proof that every runtime process avoids SIGKILL. OpenShell may kill the workload before its handler finishes.
Release Notes
Testing
Other compute drivers and amd64 CI have not been exercised locally. The unchanged supervisor still waits for forced killing in this Kubernetes setup, even when public deletion completes within the deadline. This PR contains only the test, not the #5279 fix; it is expected to fail on builds without that fix.
Checklist