Repository navigation
Python: preserve target script arguments in the profiling CLI - #181
Open
codewithfourtix wants to merge 2 commits into
Open
codewithfourtix wants to merge 2 commits into
codewithfourtix wants to merge 2 commits into
Conversation
Signed-off-by: Ali Zulfiqar <169186637+codewithfourtix@users.noreply.github.com>
Signed-off-by: Ali Zulfiqar <169186637+codewithfourtix@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python -m nvtx train.py --batch-size 32currently rejects the script's options, while--helpor--no-linenosare consumed by NVTX. Stop parsing profiler options at the script path so the target receives its arguments unchanged.Validation: focused CLI tests pass for unknown flags, colliding flags,
--help,--, and profiler options before the script. The four forwarding cases fail on the original code. Native profiler mocked; full native suite not run.