Repository navigation
Conversation
Signed-off-by: Rio Yu <52408936+rioyu123@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python script.pyputs the script's directory first onsys.path, so it can import modules that sit next to it.python -m nvtx script.pyusesrunpy.run_path, which does not do this for a file path. A sibling import can therefore fail withModuleNotFoundErroror pick up a different module from the current directory.This change adds the script's absolute directory to the front of
sys.pathbefore execution, following the standard library'scProfileandprofilecommand-line tools. It leaves argument parsing and profiling behavior unchanged.Testing:
--enable-injection(4,469 passed in each run).Related: #181 fixes argument forwarding, not import paths. Both changes touch the CLI and add
test_main.py, so whichever merges second may need a small rebase. This PR does not include #181's changes.