Skip to content

fix: ignore held key repeat for popup hotkey #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noxygalaxy merged 1 commit into from
Aug 16, 2026
Merged

fix: ignore held key repeat for popup hotkey #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src-tauri/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ fn setup_global_shortcut(app: &AppHandle) -> Result<(), Box<dyn std::error::Erro
let mut shift = false;
let mut alt = false;
let mut meta = false;
let mut trigger_held = false;

if let Err(e) = listen(move |event| match event.event_type {
EventType::KeyPress(Key::ControlLeft) | EventType::KeyPress(Key::ControlRight) => {
Expand Down Expand Up @@ -438,6 +439,9 @@ fn setup_global_shortcut(app: &AppHandle) -> Result<(), Box<dyn std::error::Erro
meta = false;
}
EventType::KeyPress(key) => {
if trigger_held {
return;
}
let matches = app_handle
.try_state::<PopupHotkey>()
.and_then(|state| {
Expand All @@ -454,6 +458,7 @@ fn setup_global_shortcut(app: &AppHandle) -> Result<(), Box<dyn std::error::Erro
.unwrap_or(false);

if matches {
trigger_held = true;
let now = std::time::Instant::now();
let mut trigger = false;

Expand All @@ -473,6 +478,7 @@ fn setup_global_shortcut(app: &AppHandle) -> Result<(), Box<dyn std::error::Erro
}

if trigger {
trigger_held = false;
let ah = app_handle.clone();
tauri::async_runtime::spawn(async move {
if let Err(e) = open_popup(&ah).await {
Expand All @@ -488,6 +494,9 @@ fn setup_global_shortcut(app: &AppHandle) -> Result<(), Box<dyn std::error::Erro
}
}
}
EventType::KeyRelease(_) => {
trigger_held = false;
}
_ => {}
}) {
log::error!("Global shortcut listener crashed: {:?}", e);
Expand Down
Loading