fix: ignore held key repeat for popup hotkey - #16
Merged
Conversation
gmcky
marked this pull request as ready for review
August 8, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holding the popup hotkey (e.g. Ctrl+C) let OS key auto-repeat count as
repeated presses, so a held combo opened the popup on its own. Track the
trigger key as held and ignore repeats until it is released, so only real
double-taps open the popup.
Verify:
Tested on Windows. The rdev key event flow is the same on macOS and Linux,
so the fix should behave identically there; no separate cross-platform test
needed.
Ready to merge from my side.