Repository navigation
Add per-face redstone drawer and machine reservation overlays - #94
Merged
Merged
Conversation
Collaborator
|
Overall up to your usual quality :) Must Fix:
Should Fix:
Nits:
|
Collaborator
|
Looking good -- the hoppers able to push into an output slot and the unsided energy access don't seem to have been addressed, but the rest have. Good work! |
Collaborator
Author
|
the crusher's output slots are open for testing reasons :)... so it's easy to test machine with full output without waiting 30 cycles... :) will try to find an example of the energy stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machine screens now provide per-face redstone control through a dedicated drawer, and show recipe reservations directly on machine item slots.
IRedstoneOutputAPI supplies stable IDs, translated labels, colours/sprites, and server-side signal suppliers; each processor contributes its own entries.-nand reserved output as+nat the top right of machine slots. Stack counts use the same size; empty reserved output slots show a 50% ghost item. These are visual previews only.Validation:
check build: 130 JUnit tests, 69 library GameTests, 37 companion GameTests, and packaging/import/asset checks passed.GUI protocol advances from 6 to 10; clients and servers need matching MMDLib builds. Existing companion global redstone settings migrate to the per-face configuration.