Repository navigation
Add extensible machine statistics and generator side configuration - #95
Merged
Merged
Conversation
Collaborator
|
Okay, I'm not feeling well, so I gave Claude the lead on this review: Should be fixed before merging
Worth fixing
Repeats from earlier reviews (already known, not new in this PR)
My overall take: 1 and 2 make the new feature show wrong information, and 3 is the one with real gameplay consequences on a server. I'd ask for those three before merging. 4 and 5 are quick fixes, and 6 and 7 can wait. |
Base automatically changed from
codex/redstone-control-drawer
to
master-2.0-1.21.1-neo
November 7, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machine screens gain a Statistics drawer below Info, supplied by a public
StatsProvidercontract implemented by individual machine parts.Review follow-up for the review comment:
HELDstatus while preserving progress and reservations. Manual pause retains priority; the Info drawer shows the specific redstone/reserve warning.The previously accepted Curios discovery tradeoff remains unchanged.
Validation:
check build runCompanionClientSmokepassed: 150 unit tests, 69 library and 42 companion server GameTests, packaging/import/asset checks, and all five companion menus.