Repository navigation
Add player equipment, optional Curios/backpack drawers, and session drawer memory - #93
Merged
Merged
Conversation
Collaborator
|
You dodged a lot of bits I was concerned about, so good job! Must Fix:
Should Fix:
Cleanups:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machine screens now expose player equipment and optional equipped storage directly, with consistent drawers that remember their state across machines during the current world/server session.
Changes
Validation
check build: 130 JUnit tests, 69 library GameTests, 36 companion GameTests, and release-jar checks passed.runCompanionClientSmoke: all five menus, real Curios/backpack interactions, and cross-machine drawer memory passed.runCompanionClientSmoke -PwithoutBackpackspassed with optional mods absent.build --offlineandgit diff --checkpassed.GUI protocol is now version 6, so clients and servers need matching MMDLib builds. Backpack upgrades/crafting/settings UI is outside this storage integration.