Skip to content

feat(pr-workflow): add review-thread conduct and the core overlay #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MajorLift wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(pr-workflow): add review-thread conduct and the core overlay #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee175c9
Say when an agent may resolve a review thread, and give `core` an ove…
MajorLift Sep 22, 2026
312d3f6
Never collapse a human's comment without being asked
MajorLift Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions domains/pr-workflow/skills/pr-guidelines/repos/core.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
repo: core
parent: pr-guidelines
---

## Reviewing Pull Requests

### Resolving Review Threads

Applies to agents in particular, where the cost of getting this wrong is a thread closed before its reviewer read it.

- **Never resolve, minimize or hide a comment a human wrote, unless that human explicitly asks you to.** Collapsing a comment takes it out of the default view and asserts the matter is settled, which is a judgement belonging to whoever raised it. Doing it on a principal's behalf makes that assertion in their name.
- **Never resolve a review thread before human reviewers have had time to read new comments and respond.** This is a hard rule, not a convention.
- **Do not resolve threads unilaterally.** Prefer to let the human reviewers engaging with a thread close it once they have determined the raised issues are resolved.
- **Leave a thread open if it may be relevant, educational, or of future reference value.** Most threads should still be closed to avoid clutter.
- **Do not re-post on an unresolved thread that has not been updated.** Resolving every thread is not a merge requirement in this repo, unlike Mobile, so an unresolved thread is not by itself a signal that anything is outstanding.
10 changes: 10 additions & 0 deletions domains/pr-workflow/skills/pr-guidelines/repos/metamask-extension.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,16 @@ When NOT to use:
- Non-blocking suggestions
- Nitpicks

### Resolving Review Threads

Applies to agents in particular, where the cost of getting this wrong is a thread closed before its reviewer read it.

- **Never resolve, minimize or hide a comment a human wrote, unless that human explicitly asks you to.** Collapsing a comment takes it out of the default view and asserts the matter is settled, which is a judgement belonging to whoever raised it. Doing it on a principal's behalf makes that assertion in their name.
- **Never resolve a review thread before human reviewers have had time to read new comments and respond.** This is a hard rule, not a convention.
- **Do not resolve threads unilaterally.** Prefer to let the human reviewers engaging with a thread close it once they have determined the raised issues are resolved.
- **Leave a thread open if it may be relevant, educational, or of future reference value.** Most threads should still be closed to avoid clutter.
- **Do not re-post on an unresolved thread that has not been updated.** Resolving every thread is not a merge requirement in this repo, unlike Mobile, so an unresolved thread is not by itself a signal that anything is outstanding.

## Receiving Feedback

### Be Open to Other Perspectives
Expand Down
Loading