Conversation
…rlay `pr-guidelines` is a base skill whose description covers reviewing someone else's PR, and it had no `repos/core.md`. `tools/install` skips a skill whose `repos/` holds no file for the target repo, so `core` received none of it.
Resolving, minimizing and hiding all take a comment out of the default view, which asserts the matter is settled. That judgement belongs to whoever raised it, and an agent making it on a principal's behalf makes it in their name.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
## Reviewing Pull Requestsinpr-guidelines' extension overlay: when an agent may resolve a thread, when to leave one open, and when not to re-post on an unresolved one.repos/core.md, which this skill did not have.tools/installskips a skill entirely whenrepos/exists without a file for the target repo, socorewas receiving nothing from a base skill whose own description covers reviewing someone else's PR.Test plan
node --test test/*.test.mjspasses 71 of 71.node .github/scripts/lint-skill-entry.mjs domains/pr-workflow/skills/pr-guidelines/skill.mdreports 0 errors. The two warnings for missing recommended sections are pre-existing on a frontmatter-onlyskill.md.corenow deliverspr-guidelines, where before it was skipped.