Skip to content

Don't add --wait or --yes to swap commands #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaitanyapotti merged 1 commit into from
Oct 22, 2026
Merged

Don't add --wait or --yes to swap commands #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions skills/metamask-agent-wallet/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ When raw calldata is unfamiliar or was not constructed by you, run `mm decode --
In both server-wallet and BYOK mode, signing and transaction commands go through a job-polling loop and return a `pollingId`. Handle this consistently:

1. Prefer `--wait` to block until complete.
Swap commands (`swap quote`, `swap execute`, `swap status`) do not support `--wait`; use `swap status --quote-id` to poll progress instead.
2. If not using `--wait`, inform the user of the `pollingId` and how to track it:
- `mm wallet requests list`
- `mm wallet requests watch <polling-id>`
Expand Down
2 changes: 2 additions & 0 deletions skills/metamask-agent-wallet/references/swap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,8 @@ When the user has chosen a specific route, such as "use Across", and the origina

## Notes

- Swap commands do not support `--wait`. Track progress with `mm swap status --quote-id <id>` after execution.
- Don't add `--yes` unless the user explicitly asked for unattended execution. The default flow is quote → user review → execute by quote ID.
- If the chain is not mentioned by the user, ask for the chain.
- Use `mm chains list` to discover supported chain IDs.
- Same-chain swap: omit `--to-chain-id`, which defaults to `--from-chain-id`.
Expand Down
1 change: 1 addition & 0 deletions skills/metamask-agent-wallet/workflows/bridge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Reference command syntax in `references/swap.md`. The CLI uses the same `swap` c
3. Execute and track status.

Don't skip the quote review step. The user needs to see output amount, fees, route, and slippage before executing.
Don't add `--yes` unless the user explicitly asked for unattended execution.

## Quote

Expand Down
1 change: 1 addition & 0 deletions skills/metamask-agent-wallet/workflows/swap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Reference command syntax in `references/swap.md`.
3. Execute and track status.

Don't skip the quote review step. The user needs to see output amount, fees, route, and slippage before executing.
Don't add `--yes` unless the user explicitly asked for unattended execution.

## Quote

Expand Down
Loading