Skip to content

Don't add --wait or --yes to swap commands - #65

Merged
chaitanyapotti merged 1 commit into
mainfrom
fix/swap-wait-yes-guardrails
Oct 22, 2026
Merged

chaitanyapotti merged 1 commit into
mainfrom
fix/swap-wait-yes-guardrails

Conversation

@hieu-w

@hieu-w hieu-w commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Motivation and Context

Agents frequently add --wait and --yes to swap commands (mm swap quote, mm swap execute, mm swap status) even though:

  • --wait is not supported on any swap command. The Async Model in SKILL.md says "Prefer --wait to block until complete" with no swap exception (perps already says they do not use --wait).
  • --yes is valid on swap quote only, but the swap/bridge workflows are quote → confirm → execute. Agents were adding --yes by default instead of waiting for user review.

Jira Link

N/A

Description

Documentation-only guardrails so agents stop treating swaps like waitable, unattended jobs:

  • SKILL.md Async Model: swap commands do not support --wait; poll with swap status --quote-id instead.
  • references/swap.md Notes: same --wait exclusion, plus do not add --yes unless the user explicitly asked for unattended execution.
  • workflows/swap.md and workflows/bridge.md: same --yes default-flow guardrail after the quote-review step.

No CLI behavior change. --yes remains documented on swap quote for unattended use, and still cannot be combined with --all-quotes.

How has this been tested?

  • Read the four modified files to confirm the guardrails are consistent.
  • Grepped --wait and --yes across the skill. Remaining --yes mentions document the flag, the --all-quotes conflict, and the re-quote rule; nothing still tells agents to prefer --wait on swaps.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This repo has no test suite for skill docs. The change is wording in SKILL.md, references/swap.md, and the swap/bridge workflows.

…o --yes.

Agents were applying the global async --wait preference and unattended --yes to quote/execute/status even though swaps poll via status and the default flow is quote, review, then execute by ID.
@hieu-w
hieu-w requested a review from a team as a code owner October 21, 2026 14:57
@hieu-w hieu-w changed the title Clarify that swap commands do not use --wait and should not default t… Clarify that swap commands do not use --wait and should not default to --yes Oct 21, 2026
@hieu-w hieu-w changed the title Clarify that swap commands do not use --wait and should not default to --yes Don't add --wait or --yes to swap commands Oct 21, 2026
@chaitanyapotti
chaitanyapotti merged commit e87ac50 into main Oct 22, 2026
11 checks passed
@chaitanyapotti
chaitanyapotti deleted the fix/swap-wait-yes-guardrails branch October 22, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants