docs(fold): the #414 review's follow-ups for Metal's OCRBench section - #417
Merged
Merged
Conversation
Follows CUDA's review of #414 (5882125367). - OCRBench "carries no grammar", so it no longer reads against the think-off line above it. - Item 0 was the deployed run's one undrafted request (the first after the cold start), so for drafting the repeat rests on the other 199 rows. - The think-off attribution against 0.34.0 adds ADR 0039 as a third, unseparated candidate beside the MLX move and XGrammar. - The bare comment ids become links. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Review of #417 at Verified:
Nits, none blocking:
|
glennneuber
added a commit
that referenced
this pull request
Sep 29, 2026
docs(fold): the #417 review's two wording nits for Metal's OCRBench section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the follow-ups from CUDA's review of #414 (5882125367). It changes docs only: the Metal section of the fold record. The numbers are the review's.
pull/412#issuecomment-5881649818andpull/375#issuecomment-5824799988.speculative decode statsline showsdrafted=0. Its 9.2 s includes the load. So for drafting, the 200-of-200 repeat rests on the other 199 rows. The record says so, and "as OCRBench's rows 0–199 did" becomes "as 199 of OCRBench's rows 0–199 did".Follow-up 4 is 5856289579's own "Not attributable to the build" line. It gets a correction comment on #375 once this is open.
check_source_paths.py --changed-since origin/mainand the name scan are clean.macbook-pro-m5-max-128GB/mlx-metal🤖 Generated with Claude Code