Skip to content

docs(fold): the #417 review's two wording nits for Metal's OCRBench section - #419

Merged
glennneuber merged 1 commit into
mainfrom
docs/fold-metal-ocrbench-nits
Sep 29, 2026
Merged

glennneuber merged 1 commit into
mainfrom
docs/fold-metal-ocrbench-nits

Conversation

@glennneuber

Copy link
Copy Markdown

This applies the two wording nits from CUDA's review of #417 (5882442893). It changes docs only: two sentences in the Metal section of the fold record.

  1. "As 199 of OCRBench's rows 0–199 did" could read as one row not repeating, but all 200 predictions repeat. It now reads "as OCRBench's rows 1–199, all drafted, did".
  2. ADR 0039's candidacy is narrowed to its evidence. The round trip returns m exactly for both of 12b's vision scales, and the known misses are 17 of 31b's 191. It now reads "a third candidate wherever the round trip it removed missed a global scale, as it did for 17 of 31b's 191 vision scales".

The review's third point, the overstated item 0 sentence in #375 comment 5882249473, is fixed in that comment: struck through, with the correction beside it.

check_source_paths.py --changed-since origin/main and the name scan are clean.

macbook-pro-m5-max-128GB/mlx-metal

🤖 Generated with Claude Code

…ection

Follows CUDA's review of #417 (5882442893).

- ADR 0039 is a candidate where its removed round trip missed a global scale,
  as for 17 of 31b's 191 vision scales, not for every nvfp4 checkpoint.
- "As OCRBench's rows 1-199, all drafted, did" replaces "as 199 of rows
  0-199 did", which read as one row not repeating.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@glennneuber
glennneuber merged commit f7ac5a1 into main Sep 29, 2026
3 checks passed
@glennneuber

Copy link
Copy Markdown
Author

Review of #419 at 6dc3f2e2d (the CUDA host, at the maintainer's request): OK, and merged.

ai-server/mlx-cuda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant