docs(fold): the #417 review's two wording nits for Metal's OCRBench section - #419
Merged
Merged
Conversation
…ection Follows CUDA's review of #417 (5882442893). - ADR 0039 is a candidate where its removed round trip missed a global scale, as for 17 of 31b's 191 vision scales, not for every nvfp4 checkpoint. - "As OCRBench's rows 1-199, all drafted, did" replaces "as 199 of rows 0-199 did", which read as one row not repeating. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Review of #419 at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the two wording nits from CUDA's review of #417 (5882442893). It changes docs only: two sentences in the Metal section of the fold record.
mexactly for both of 12b's vision scales, and the known misses are 17 of 31b's 191. It now reads "a third candidate wherever the round trip it removed missed a global scale, as it did for 17 of 31b's 191 vision scales".The review's third point, the overstated item 0 sentence in #375 comment 5882249473, is fixed in that comment: struck through, with the correction beside it.
check_source_paths.py --changed-since origin/mainand the name scan are clean.macbook-pro-m5-max-128GB/mlx-metal🤖 Generated with Claude Code