Skip to content

fix(view): View menu with three sizes, no icons, no shortcuts - #42

Merged
Maxaubert merged 2 commits into
mainfrom
fix/41-view-menu
Oct 5, 2026
Merged

Maxaubert merged 2 commits into
mainfrom
fix/41-view-menu

Conversation

@Maxaubert

Copy link
Copy Markdown
Owner

Closes #41

What changed

  • View menu lists only Details, Tiles and Extra large icons as plain text rows, with a check mark on the current one (none checked when the size is one the menu does not list; focus then lands on the first entry). No size glyphs, no shortcut text, no Reset row, no hint rows.
  • Removed the Ctrl+Shift+1..6 per-size shortcuts (model, tests, spec). Large details, Medium icons and Large icons are reached with Ctrl+wheel.
  • Kept: Ctrl+wheel over the list (all six sizes), Ctrl+= / Ctrl++ / Ctrl+Shift+= bigger, Ctrl+- smaller, Ctrl+0 back to Details. These step like zoom and also stop Electron's page zoom accelerators.
  • Toolbar View button: no glyph before the label, chevron kept; the label still names the current size, any of the six.
  • Removed the seven now-unused icons (view-*, mouse) from the registry.
  • Spec doc and redesign-direction note updated; e2e/visual.spec.ts now steps sizes with Ctrl+=. Version 0.7.2.

Verification

  • typecheck, lint, prettier --check, npm test (836 passed), build: clean
  • Playwright viewsizes, ui, rowmenu: 17 passed, 1 skipped (the big-thumbnail test, which needs tool binaries)
  • Screenshot of the open menu: docs/mockups/view-zoom/shots/impl-menu.png
  • Packaged, installed 0.7.2 silently and launched it on this machine

Unsigned build, as usual.

🤖 Generated with Claude Code

Maxaubert and others added 2 commits October 5, 2026 22:32
The View menu now offers only Details, Tiles and Extra large icons as plain
text rows with a check mark; the Reset row and hint rows are gone. The
Ctrl+Shift+1..6 size shortcuts are removed. Ctrl+wheel and Ctrl+= / Ctrl+- /
Ctrl+0 still step through all six sizes, and the toolbar button names the
current size (any of six) without a leading glyph. Unused view icons are
removed from the registry. Version 0.7.2.

Closes #41

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	docs/mockups/view-zoom/shots/impl-menu.png
#	package-lock.json
#	package.json
@Maxaubert
Maxaubert merged commit 0a67b00 into main Oct 5, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View menu: three sizes, no icons, no key bindings

1 participant