fix: hidden e2e windows, no Generate toolbar button, empty Generate state - #40
Merged
Merged
Conversation
…tate
- e2e: every spec launches through launchApp() in e2e/helpers.ts, which sets
FILESMITH_E2E_HIDDEN=1. The main process then keeps the window hidden
(paintWhenInitiallyHidden, no background throttling, no taskbar entry) and
never calls show() or focus(), so a test run no longer steals focus.
Screenshots still render. The Ctrl+C console helper starts hidden.
- Generate: the toolbar row keeps its 32px height and shows the image count;
Run and Stop live only in the inspector footer.
- Generate with no model: one calm block ("No image model yet" with Choose
ComfyUI folder / Add a model), Generate stays off with a short reason, and
the centre empty state says what to do. Settings says "Choose folder" when
no ComfyUI folder is set.
- Lint and prettier skip .claude/worktrees.
- Version 0.7.1.
Refs #38
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #38 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
What changed
Headless e2e. Every spec now launches through
launchApp()ine2e/helpers.ts, which setsFILESMITH_E2E_HIDDEN=1. With that flagsrc/main/index.tscreates the window withpaintWhenInitiallyHidden,backgroundThrottling: falseandskipTaskbar, never callsshow()onready-to-show, and does not restore or focus it onsecond-instance. The flag is read only from the environment, so the packaged app behaves as before. The Ctrl+C console helper (e2e/ctrlc-console.ps1, started bycli-packed.spec.ts) now opens hidden instead of minimized, and the test still passes. No off-screenshowInactive()fallback was needed: hidden windows paint, so screenshots render.Generate toolbar. The Generate and Cancel buttons are gone from the centre toolbar. The 32px row stays so it lines up with the inspector tabs, and it shows the image count on the right (
0 images, orGenerating), like the file count on the other tabs. Run and Stop live only in the inspector footer.Generate with no model. Before, the inspector showed a "ComfyUI was not found" warning, an empty Model row ("No image models found in your ComfyUI models folder" when no folder existed), a "Change ComfyUI folder" button with no folder set, and three ways to pick a folder. Generate also turned on as soon as a prompt was typed and then failed. Now:
The generate status is now shared between the inspector and the Run button, so picking a folder updates both. The pure helpers are in
genReady.ts, with tests.Tooling. Lint and prettier skip
.claude/worktrees(in-repo worktrees madenpm run lintfail).Version 0.7.1.
Screenshots
docs/mockups/generate-empty/before.png: Generate tab with no model, beforedocs/mockups/generate-empty/after.png: afterdocs/mockups/generate-empty/settings.png: Settings > Tools, ComfyUI folder "Not set"docs/mockups/terminal-v5/shots/anddocs/mockups/view-zoom/shots/were re-made, hidden, with this build.Verification
npm run typecheck,npm run lint,npx prettier --check .: cleannpm test: 89 files, 857 passed, 1 skippednpm run build && npm run test:e2e(afternpm run packagefor the packed-CLI specs): 77 passed, 2 skipped. The 2 skips are the FILESMITH_SHOTS-only captures, which passed in an earlier full run withFILESMITH_SHOTS=1. The GPU tests (real ComfyUI generate, upscale) passed. In that earlier run, before packaging, the 2cli-packedversion tests failed becausedist/still held 0.7.0; they pass against the 0.7.1 package.MainWindowHandle. The foreground window stayed on the owner's browser for the whole run.e2e/generate-empty.spec.ts: fresh userData and a throwaway USERPROFILE. It checks the empty block, that Generate stays disabled with and without a prompt, the shown reason, and that the toolbar has no buttons.Filesmith-Setup-x64-0.7.1.exe. The installed exe reports 0.7.1 and launches normally (a visible window, as before).Unsigned build, as expected.
🤖 Generated with Claude Code