Bundle dqrobotics.dll into the Windows wheels - #9
Merged
Merged
Conversation
The new smoke test found that the Windows wheels cannot be imported: "ImportError: DLL load failed while importing _core: The specified module could not be found." _core links dqrobotics.dll (installed to C:/dqrobotics/bin), which the wheel did not include, so every Windows job of the publish run on main failed and nothing was published. delvewheel repair bundles it, as auditwheel and delocate do on Linux and macOS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The smoke test added in #8 found that the Windows wheels cannot be imported:
_corelinksdqrobotics.dll, which is installed toC:/dqrobotics/binon the runner but was not included in the wheel. All five Windows jobs of the publish run onmainfailed, so no release was published. The Windows wheels already on PyPI (26.9.8) presumably have the same problem whereverdqrobotics.dllis not on the DLL search path.This adds a
delvewheel repair --add-path C:/dqrobotics/binstep for Windows, the counterpart ofauditwheel(Linux) anddelocate(macOS).Test plan
🤖 Generated with Claude Code