Repository navigation
Preserve typed native wavefunction precision failures - #23
Draft
huashengshao wants to merge 1 commit into
Draft
huashengshao wants to merge 1 commit into
huashengshao wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve FeynKit's typed external-state precision failures through strict native wavefunction evaluation.
RusticolErrorKind::InsufficientPrecision { bits }carries the batch's requested working precision and lane context, so a caller can rebuild from exact inputs at a wider precision. A component's lower tracked precision does not replace that working-precision metadata. Nonfinite computed results and malformed input retain their separate classifications.Advance the coherent native family to FeynKit
ee18b8e6386cb36ca88b1917e00ab2ebae93e68eand Ninjaa069504e3dc884d6e2682aadc75fb12a7f4e7c07. This PR is stacked oncodex/native-tree-color-correlations(PR22), so its diff contains only the new error contract, native conversion, four regressions and dependency/lock updates. The existing partial-state API still returns textual statuses; its documented regression checks sparse failure without inserting a successful zero.Validation: all 100 native tests pass on the combined source, including the existing model preparation, numerical reduction, QCD Ward/boost/precision, scalar loop and color-correlation checks. The four new tests cover fresh wider reconstruction, requested-versus-tracked bits, partial-row behavior and precision-versus-range/input classification. The same complete prebuilt suite also passes with
PATH=/nonexistent. The FeynKit owner passes 45 tests with a failing old-source regression control; Ninja's vector parity and transactional precision-error tests pass and its source change was independently reviewed. Root consumers still need to map this new typed variant into their own retry error before adopting these pins.