Repository navigation
Disambiguate native comparisons for shared Python hosts - #24
Draft
huashengshao wants to merge 1 commit into
Draft
huashengshao wants to merge 1 commit into
huashengshao wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linking the native provider into a shared Python host with rkyv/Spenso support exposes additional
PartialEqandFromIteratorimplementations. Seven set comparisons then become ambiguous, and the runtime-name comparison needs an explicit string slice. Specify the intendedBTreeSet<_>collections andruntime_name.as_str(); algorithms, public APIs, dependency pins and existing tests remain unchanged.This targeted PR is stacked on #23 (
codex/native-wavefunction-precision, exact base438cacad24b500585d084fa437dd99da5aaf074a) so its diff contains only these compatibility changes.Validation: an isolated consumer using the ROULETTE standalone PyO3 0.28.3 host, FeynKit
ee18b8eand the Symbolica/Numerica/Graphicae93c3c7family successfully checked the patchedrusticol-core,rusticol-loop-reductionandroulette-native-amplitudes. The overall host check then stopped in separately staged ROULETTE stub-generation annotations whose dependency was not yet enabled; complete host/import success is not claimed. Independent source review found no actionable issue. No runtime algorithms changed, and no new runtime test claim is made.