Skip to content

fix: stop creating checkpoint lock files in StorageManager constructor #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 1 commit into from
Jul 15, 2026
Merged

fix: stop creating checkpoint lock files in StorageManager constructor #689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/storage/storage_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,11 @@ StorageManager::StorageManager(const std::string& databasePath, bool readOnly, b
shadowFile =
std::make_unique<ShadowFile>(*memoryManager.getBufferManager(), vfs, this->databasePath);
inMemory = main::DBConfig::isDBPathInMemory(databasePath);
if (!readOnly && !inMemory) {
vfs->openFile(StorageUtils::getCheckpointIntentLockFilePath(databasePath),
FileOpenFlags(
FileFlags::READ_ONLY | FileFlags::WRITE | FileFlags::CREATE_IF_NOT_EXISTS));
vfs->openFile(StorageUtils::getCheckpointApplyLockFilePath(databasePath),
FileOpenFlags(
FileFlags::READ_ONLY | FileFlags::WRITE | FileFlags::CREATE_IF_NOT_EXISTS));
}
// Checkpoint intent/apply lock files (*.checkpoint.intent.lock and
// *.checkpoint.apply.lock) are NOT created here. All access, including subgraph
// access, goes through the main database path returned by
// clientContext.getDatabasePath(). The Checkpointer creates these files on demand
// (with CREATE_IF_NOT_EXISTS) when a checkpoint starts via acquireCheckpointLocks().
registerIndexType(PrimaryKeyIndex::getIndexType());
registerIndexType(ArtPrimaryKeyIndex::getIndexType());
}
Expand Down
Loading