fix: stop creating checkpoint lock files in StorageManager constructor#689
Merged
Conversation
The checkpoint intent/apply lock files (*.checkpoint.intent.lock and *.checkpoint.apply.lock) were being created as empty placeholders by every StorageManager constructor, including for subgraph databases (e.g. test.mygraph1.db). These files are unnecessary because all access (including subgraph access) goes through the main database path via clientContext.getDatabasePath(). The files are already created on demand by Checkpointer:: acquireCheckpointLocks() (with CREATE_IF_NOT_EXISTS) when a checkpoint actually starts, and cleaned up by releaseCheckpointLocks() after the checkpoint completes. Pre-creating them in the StorageManager constructor was redundant and caused stale files to leak on disk for subgraph databases that are checkpointed via collectCheckpointTargets() but never have their own locks acquired or released.
Contributor
Author
|
Cc: @ericyuanhui |
Contributor
|
Looks perfect! No issues with this modification at all. Thank you so much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkpoint intent/apply lock files (*.checkpoint.intent.lock and *.checkpoint.apply.lock) were being created as empty placeholders by every StorageManager constructor, including for subgraph databases (e.g. test.mygraph1.db). These files are unnecessary because all access (including subgraph access) goes through the main database path via clientContext.getDatabasePath().
The files are already created on demand by Checkpointer:: acquireCheckpointLocks() (with CREATE_IF_NOT_EXISTS) when a checkpoint actually starts, and cleaned up by releaseCheckpointLocks() after the checkpoint completes. Pre-creating them in the StorageManager constructor was redundant and caused stale files to leak on disk for subgraph databases that are checkpointed via collectCheckpointTargets() but never have their own locks acquired or released.