Repository navigation
feat: skip CI jobs a change cannot affect, gated on the paths it touched #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ejfine
wants to merge
3
commits into
main
Choose a base branch
from
feat/ci-path-classes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Path classes for the `changes` job in .github/workflows/ci.yaml. Every top-level key becomes a boolean in that job's | ||
| # `classes` output, read as fromJSON(needs.changes.outputs.classes).<key>, true when the change touched a matching | ||
| # path. Globs follow dorny/paths-filter (picomatch); a leading `!` excludes. | ||
| # | ||
| # `code` is every path a build, test or packaging job may depend on, so exclude only paths no such job reads. A code | ||
| # path that no other class claims switches every class on, which means an unlisted path can never cause a job to be | ||
| # skipped. A project that builds its documentation excludes the sources here and claims them in a class of its own | ||
| # that gates the docs job. Project classes go below `code`. | ||
| code: | ||
| - '**' | ||
| - '!**/*.md' | ||
| - '!.coderabbit.yaml' | ||
| - '!**/*.mmd' | ||
| - '!*.code-workspace' | ||
| - '!.github/ISSUE_TEMPLATE/**' | ||
| - '!LICENSE' | ||
| # unit-level tests never reach a build artifact; their own classes still run them{% if has_backend %} | ||
| - '!backend/tests/unit/**'{% endif %} | ||
| - '!frontend/tests/unit/**' | ||
| - '!frontend/tests/compiled/**' | ||
| frontend: | ||
| - 'frontend/**' | ||
| - 'pnpm-lock.yaml' | ||
| - 'pnpm-workspace.yaml'{% if has_backend %} | ||
| - 'backend/tests/unit/__snapshots__/test_basic_server_functionality/test_openapi_schema.json' | ||
| backend: | ||
| - 'backend/**' | ||
| - 'pytest.ini'{% endif %}{% if install_as_windows_service %} | ||
| installer: | ||
| - 'installer/**' | ||
| - '!installer/**/*.md'{% endif %} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: LabAutomationAndScreening/copier-nuxt-python-intranet-app
Length of output: 6475
🏁 Script executed:
Repository: LabAutomationAndScreening/copier-nuxt-python-intranet-app
Length of output: 5286
🏁 Script executed:
Repository: LabAutomationAndScreening/copier-nuxt-python-intranet-app
Length of output: 7803
🏁 Script executed:
Repository: LabAutomationAndScreening/copier-nuxt-python-intranet-app
Length of output: 2300
Run compiled frontend tests for compiled-test changes.
In a Docker rendering, a compiled-test-only change sets
frontendbut notcode. The job-level conditions skipbuild-frontendand, whenhas_backendis enabled,build-backend.test-compiled-frontend-devthen skips because it needs those jobs.Remove the exclusion:
Allow compiled tests to set
code- - '!frontend/tests/compiled/**'If the exclusion remains, allow every required build job to run when either
codeorfrontendis true:Allow the required builds for frontend changes
Apply this change to both
build-frontendand the Dockerbuild-backendblock:🤖 Prompt for AI Agents