Skip to content

Render devcontainer.json without trailing commas #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejfine merged 1 commit into from
Oct 13, 2026
Merged

Render devcontainer.json without trailing commas #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions template/.devcontainer/devcontainer.json.jinja-base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,20 @@
// and it breaks creation of the devcontainer since pre-commit hooks are already in place. Probably a better way to fix this but until we use git-lfs we can leave it like this.
// https://github.com/devcontainers/features/blob/main/src/git-lfs/README.md
"autoPull": false
},{% endraw %}{% if is_child_of_copier_base_template is not defined %}{% raw %}
}{% endraw %}{% if is_child_of_copier_base_template is not defined %}{% raw %},
"ghcr.io/devcontainers/features/aws-cli:1.1.4": {
// https://github.com/devcontainers/features/blob/main/src/aws-cli/devcontainer-feature.json
// view latest version https://raw.githubusercontent.com/aws/aws-cli/v2/CHANGELOG.rst
"version": "2.36.49"
},{% endraw %}{% endif %}{% raw %}{% endraw %}{% if is_child_of_copier_base_template is not defined and template_uses_typescript is defined and template_uses_typescript is sameas(true) %}{% raw %}
}{% endraw %}{% endif %}{% raw %}{% endraw %}{% if is_child_of_copier_base_template is not defined and template_uses_typescript is defined and template_uses_typescript is sameas(true) %}{% raw %},
"ghcr.io/devcontainers/features/node:2.1.0": {
// https://github.com/devcontainers/features/blob/main/src/node/devcontainer-feature.json
"version": "{% endraw %}{{ node_version }}{% raw %}",
"pnpmVersion": "{% endraw %}{{ pnpm_version }}{% raw %}",
"nvmVersion": "{% endraw %}{{ nvm_version }}{% raw %}",
},{% endraw %}{% endif %}{% raw %}{% endraw %}{% if install_claude_cli %}{% raw %}
"nvmVersion": "{% endraw %}{{ nvm_version }}{% raw %}"
}{% endraw %}{% endif %}{% raw %}{% endraw %}{% if install_claude_cli %}{% raw %},
// https://github.com/anthropics/devcontainer-features/blob/main/src/claude-code/devcontainer-feature.json
"ghcr.io/anthropics/devcontainer-features/claude-code:1.0.5": {},{% endraw %}{% endif %}{% raw %}
"ghcr.io/anthropics/devcontainer-features/claude-code:1.0.5": {}{% endraw %}{% endif %}{% raw %}
},
"customizations": {
"vscode": {
Expand Down Expand Up @@ -81,14 +81,14 @@
"editor.formatOnSave": true
}
}
},{% endraw %}{% if repo_names_for_codespaces_read_permissions is defined and repo_names_for_codespaces_read_permissions.strip() %}{% set _cs_repos = repo_names_for_codespaces_read_permissions.split(',') | map('trim') | reject('equalto', '') | list %}{% if _cs_repos %}
}{% endraw %}{% if repo_names_for_codespaces_read_permissions is defined and repo_names_for_codespaces_read_permissions.strip() %}{% set _cs_repos = repo_names_for_codespaces_read_permissions.split(',') | map('trim') | reject('equalto', '') | list %}{% if _cs_repos %},
"codespaces": {
"repositories": {
{% for cs_repo_item in _cs_repos %} {{ (repo_org_name ~ "/" ~ cs_repo_item) | tojson }}: {
"permissions": { "contents": "read" }
},
}{% if not loop.last %},{% endif %}
{% endfor %} }
},{% endif %}{% endif %}{% raw %}
}{% endif %}{% endif %}{% raw %}
},
"initializeCommand": "sh .devcontainer/initialize-command.sh",
"onCreateCommand": "sh .devcontainer/on-create-command.sh",
Expand Down