Corrections and upgrade from Vue2 to Vue3#877
Open
UlysseDurand wants to merge 3 commits intoKitware:masterfrom
Open
Corrections and upgrade from Vue2 to Vue3#877UlysseDurand wants to merge 3 commits intoKitware:masterfrom
UlysseDurand wants to merge 3 commits intoKitware:masterfrom
Conversation
jourdain
reviewed
Apr 13, 2026
|
|
||
| **First**, our ***trame*** imports have also changed. Thus, we will replace | ||
|
|
||
| ```python |
Collaborator
There was a problem hiding this comment.
You should keep the code from the begining of the file but update it
from trame.app import TrameApp
from trame.ui.vuetify3 import SinglePageLayout
from trame.widgets import vuetify3 as v3
from trame.widgets import vtk, trame
jourdain
reviewed
Apr 13, 2026
|
|
||
| ```python | ||
| with SinglePageWithDrawerLayout(server) as layout: | ||
| with SinglePageWithDrawerLayout(server, theme=("theme", "light")) as layout: |
Collaborator
There was a problem hiding this comment.
as self.ui
Also you should use the TrameApp base class.
jourdain
reviewed
Apr 13, 2026
| with layout.content: | ||
| # content components | ||
| with vuetify.VContainer( | ||
| with vuetify3.VContainer( |
Collaborator
There was a problem hiding this comment.
use v3 instead of vuetify3
jourdain
reviewed
Apr 13, 2026
| **Second**, we instantiate the `layout` object, create the `vtk.VtkLocalView` component, and add it directly to its `root` element using a Vuetify `VContainer` with arguments descripted in the [VTK](vtk) chapter. | ||
|
|
||
| ```python | ||
| with VAppLayout(server) as layout: |
jourdain
reviewed
Apr 13, 2026
|
|
||
| ```python | ||
| with VAppLayout(server) as layout: | ||
| with layout.root: |
jourdain
reviewed
Apr 13, 2026
| @@ -76,7 +76,7 @@ with SinglePageLayout(server) as layout: | |||
| layout.title.set_text("Hello trame") | |||
|
|
|||
| with layout.content: | |||
jourdain
reviewed
Apr 13, 2026
| children=[html_view], | ||
| ) | ||
| import paraview.web.venv | ||
| from trame.app import get_server |
Collaborator
There was a problem hiding this comment.
from trame.app import TrameApp
jourdain
reviewed
Apr 13, 2026
| from trame.app import get_server | ||
| from trame.widgets import vuetify3, paraview | ||
| from trame.ui.vuetify3 import SinglePageLayout | ||
| server = get_server() |
Collaborator
|
I would update to the structure shown here: https://kitware.github.io/trame/examples/core/basics.html#class-for-trame-application |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on Kitware/trame-tutorial#7
because trame and trame-tutorial are referencing one another.
Correct the tutorial and upgrade it from Vue2 to Vue3.