Open
Conversation
Still need to fix the dark theme in 03_html and 04_application Remember to also make changes to the tutorial's code in the doc of github.com/Kitware/trame
jourdain
reviewed
Apr 13, 2026
| @@ -1,11 +1,11 @@ | |||
| from trame.app import get_server | |||
Collaborator
There was a problem hiding this comment.
convert example using the TrameApp base class
jourdain
reviewed
Apr 14, 2026
| @@ -1,6 +1,6 @@ | |||
| from trame.app import get_server | |||
jourdain
reviewed
Apr 14, 2026
| server = get_server() | ||
| ctrl = server.controller | ||
|
|
||
| with SinglePageLayout(server) as layout: |
jourdain
reviewed
Apr 14, 2026
| from trame.ui.vuetify import SinglePageLayout | ||
| from trame.widgets import vtk, vuetify | ||
| from trame.ui.vuetify3 import SinglePageLayout | ||
| from trame.widgets import vtk, vuetify3 |
Collaborator
There was a problem hiding this comment.
from trame.widgets import vuetify3 as v3
jourdain
reviewed
Apr 14, 2026
| with SinglePageLayout(server) as layout: | ||
| layout.title.set_text("Hello trame") | ||
|
|
||
| with layout.content: |
UlysseDurand
force-pushed
the
fix-version
branch
from
a3a13f2 to
5c00c17
Compare
Some functions that don't use `self`, are put out of the class. They are only acting on VTK actors. Ref: https://github.com/Kitware/trame-tutorial/commit/ adfd845#r182468439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on Kitware/trame#877
because trame and trame-tutorial are referencing one another.
Upgrade the tutorial examples from Vue2 to Vue3.