Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ This folder is managed by [Changesets](https://github.com/changesets/changesets)

- **Add a changeset** for your change: `npm run changeset` (or `yarn`/`pnpm`/`gjsify run changeset`). Pick the affected packages and the bump type, write a one-line summary. Commit the generated `.changeset/*.md` with your PR.
- All `@learn6502/*` packages are **version-locked** (`fixed` group) — they bump together, keeping the internal `^x.y.z` ranges consistent. Changesets rewrites those internal ranges automatically on `version`, so you never hand-sync them.
- Only **`@learn6502/6502`** is published to npm; the other packages are `private` (they still get versioned + changelogged, just not published).
- Only **`@learn6502/core`** is published to npm; the other packages are `private` (they still get versioned + changelogged, just not published).

Release flow (maintainer): `npm run changeset:version` (applies pending changesets → bumps versions + internal ranges + writes CHANGELOGs), commit, then `npm run changeset:publish` (builds + `changeset publish`).
2 changes: 1 addition & 1 deletion .cursor/rules/package-app-android.mdc
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Android app with deep platform integration.
**Architecture Patterns:**

- **Services:** Centralized services in `app/services/` (lifecycle, theme, notification)
- **State Management:** Reactive state with `EventDispatcher` from `@learn6502/6502`
- **State Management:** Reactive state with `EventDispatcher` from `@learn6502/core`
- **Views:** Implement interfaces from `@learn6502/common-ui` (e.g., `MainView`, `GameConsoleView`, `DebuggerView`)
- **Widgets:** Reusable UI components in `app/widgets/` wrapping native Android widgets
- **Utils:** Platform-specific utilities in `app/utils/` (system, navigation, logger, resource helpers)
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,19 @@ jobs:
- name: Install dependencies
run: gjsify install --immutable

# Build the workspace deps that publish built output (`@learn6502/6502`,
# Build the workspace deps that publish built output (`@learn6502/core`,
# `examples`, `learn` ship `dist/*.d.ts`; `common-ui` exports source).
# Without this, type-checking common-ui/app-* fails with TS2307 "Cannot
# find module '@learn6502/6502'" — its types only exist after a build.
# find module '@learn6502/core'" — its types only exist after a build.
- name: Build workspace dependencies
run: |
gjsify workspace @learn6502/6502 build
gjsify workspace @learn6502/core build
gjsify workspace @learn6502/examples build
gjsify workspace @learn6502/learn build

- name: Type check (gjsify tsc under GJS)
run: |
gjsify workspace @learn6502/6502 check
gjsify workspace @learn6502/core check
gjsify workspace @learn6502/common-ui check
gjsify workspace @learn6502/app-web check
gjsify workspace @learn6502/app-gnome check:typescript
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-to-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:

# Build the TypeScript file content
{
echo 'import { _ } from "@learn6502/6502";'
echo 'import { _ } from "@learn6502/core";'
echo 'import type { ExampleMetaJson } from "../example-meta.ts";'
echo 'export default {'
echo " slug: \"$(esc "$SLUG")\","
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/package-managers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ jobs:
sh -c "$INSTALL"

- name: Verify workspace resolution (build 6502 → type-check common-ui)
# common-ui imports @learn6502/6502; this only type-checks if the PM
# common-ui imports @learn6502/core; this only type-checks if the PM
# symlinked the workspace + resolved the internal `^x.y.z` range to the
# local package. The lightest decisive cross-workspace check (gjs only,
# no GTK build deps). The full app-gnome build is covered by flatpak.yml.
run: |
set -eux
export PATH="$PWD/node_modules/.bin:$PATH"
gjsify workspace @learn6502/6502 build
gjsify workspace @learn6502/core build
gjsify workspace @learn6502/common-ui check
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ Required for R8/ProGuard code shrinking. Missing entries cause **runtime crashes
### Architecture

- Services: `app/services/` (lifecycle, theme, notification)
- State: reactive with `EventDispatcher` from `@learn6502/6502`
- State: reactive with `EventDispatcher` from `@learn6502/core`
- Views: implement interfaces from `@learn6502/common-ui`
- Widgets: `app/widgets/` wrapping native Android widgets
- Utils: `app/utils/` (system, navigation, logger, resources)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ To run the packages, run `gjsify run start:gnome` for the GNOME app or `gjsify r

### Releasing

Versioning, changelogs and npm publishing are managed with [Changesets](https://github.com/changesets/changesets) (see [`.changeset/README.md`](.changeset/README.md)). Add a changeset with your change (`gjsify run changeset`, or `npm`/`yarn`/`pnpm run changeset`). All `@learn6502/*` packages are version-locked and bump together; only `@learn6502/6502` is published to npm (the rest are private). Maintainer release: `… run changeset:version` then `… run changeset:publish`.
Versioning, changelogs and npm publishing are managed with [Changesets](https://github.com/changesets/changesets) (see [`.changeset/README.md`](.changeset/README.md)). Add a changeset with your change (`gjsify run changeset`, or `npm`/`yarn`/`pnpm run changeset`). All `@learn6502/*` packages are version-locked and bump together; only `@learn6502/core` is published to npm (the rest are private). Maintainer release: `… run changeset:version` then `… run changeset:publish`.

## Contributing

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@
"check:lint": "gjsify lint",
"changeset": "changeset",
"changeset:version": "changeset version",
"changeset:publish": "gjsify workspace @learn6502/6502 build && changeset publish"
"changeset:publish": "gjsify workspace @learn6502/core build && changeset publish"
},
"author": "Pascal Garber <pascal@mailfreun.de>",
"license": "GPL-3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/6502/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@learn6502/6502",
"name": "@learn6502/core",
"version": "0.7.0",
"description": "6502 assembler and simulator in Javascript",
"main": "dist/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/app-android/app/mdx/mdx-view.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import type { View } from "@nativescript/core";
import { ContentView, Builder, HtmlView } from "@nativescript/core";
import { localize } from "@nativescript/localize";
import { EventDispatcher } from "@learn6502/6502";
import { EventDispatcher } from "@learn6502/core";
import type { SourceViewEventMap, SourceViewCopyEvent } from "@learn6502/common-ui";

Check warning on line 5 in packages/app-android/app/mdx/mdx-view.ts

View workflow job for this annotation

GitHub Actions / Code Quality

eslint(no-unused-vars)

Type 'SourceViewEventMap' is imported but never used.
import { SourceView } from "~/widgets/source-view";
import { logger } from "~/utils";

Expand Down
2 changes: 1 addition & 1 deletion packages/app-android/app/states/system.states.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import type { LaunchEventData } from "@nativescript/core";
import { Application, type SystemAppearanceChangedEventData, Utils } from "@nativescript/core";
import { androidLaunchEventLocalizationHandler, overrideLocale } from "@nativescript/localize";
import { EventDispatcher } from "@learn6502/6502";
import { EventDispatcher } from "@learn6502/core";
import { ContrastMode } from "../constants";
// Direct imports to avoid circular dependency (utils/index → color → system.states → utils/index)
import { contrastLevelToMode } from "../utils/contrast";
Expand Down
2 changes: 1 addition & 1 deletion packages/app-android/app/views/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
MainEventBridge,
MainButtonState,
} from "@learn6502/common-ui";
import type { SimulatorState } from "@learn6502/6502";
import type { SimulatorState } from "@learn6502/core";

// Import services
import { notificationService } from "~/services";
Expand Down
2 changes: 1 addition & 1 deletion packages/app-android/app/views/main/debugger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
editorController,
ViewType,
} from "@learn6502/common-ui";
import type { Memory, Simulator, Assembler } from "@learn6502/6502";
import type { Memory, Simulator, Assembler } from "@learn6502/core";

// Import custom widgets
import type { MessageConsole, DebugInfo, HexMonitor, Hexdump, Disassembled } from "~/widgets/debugger";
Expand Down
2 changes: 1 addition & 1 deletion packages/app-android/app/views/main/editor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Observable } from "@nativescript/core";
import type { EditorView, EditorEventMap } from "@learn6502/common-ui";
import { editorController } from "@learn6502/common-ui";
import type { SourceView } from "~/widgets/source-view";
import { EventDispatcher } from "@learn6502/6502";
import { EventDispatcher } from "@learn6502/core";
import { logger } from "~/utils";

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/app-android/app/views/main/game-console.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { EventData, Page } from "@nativescript/core";
import type { SimulatorState } from "@learn6502/6502";
import { type Memory, type Labels, type Simulator, type Assembler } from "@learn6502/6502";
import type { SimulatorState } from "@learn6502/core";
import { type Memory, type Labels, type Simulator, type Assembler } from "@learn6502/core";

// Import child widgets
import type { Display, Gamepad } from "~/widgets/game-console";
Expand Down
4 changes: 2 additions & 2 deletions packages/app-android/app/widgets/debugger/debug-info.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ContentView, Builder } from "@nativescript/core";
import type { DebugInfoWidget } from "@learn6502/common-ui";
import type { Simulator } from "@learn6502/6502";
import { num2hex, addr2hex } from "@learn6502/6502";
import type { Simulator } from "@learn6502/core";
import { num2hex, addr2hex } from "@learn6502/core";
import type { ListItem } from "../list-item";
import { logger } from "~/utils";

Expand Down
4 changes: 2 additions & 2 deletions packages/app-android/app/widgets/debugger/disassembled.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { TextView } from "@nativescript/core";
import type { DisassembledWidget, DisassembledEventMap } from "@learn6502/common-ui";
import type { Assembler } from "@learn6502/6502";
import { EventDispatcher } from "@learn6502/6502";
import type { Assembler } from "@learn6502/core";
import { EventDispatcher } from "@learn6502/core";

export class Disassembled extends TextView implements DisassembledWidget {
readonly events = new EventDispatcher<DisassembledEventMap>();
Expand Down
4 changes: 2 additions & 2 deletions packages/app-android/app/widgets/debugger/hex-monitor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import type { GridLayout } from "@nativescript/core";
import { Label, ScrollView } from "@nativescript/core";
import type { HexMonitorWidget, HexMonitorOptions, MemoryRegion, HexMonitorEventMap } from "@learn6502/common-ui";
import { memoryRegions } from "@learn6502/common-ui";
import type { Memory } from "@learn6502/6502";
import { EventDispatcher, num2hex, addr2hex } from "@learn6502/6502";
import type { Memory } from "@learn6502/core";
import { EventDispatcher, num2hex, addr2hex } from "@learn6502/core";
import { logger } from "~/utils";

export class HexMonitor extends ScrollView implements HexMonitorWidget {
Expand Down
4 changes: 2 additions & 2 deletions packages/app-android/app/widgets/debugger/hexdump.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { TextView } from "@nativescript/core";
import type { HexdumpWidget, HexdumpEventMap } from "@learn6502/common-ui";
import type { Assembler } from "@learn6502/6502";
import { EventDispatcher } from "@learn6502/6502";
import type { Assembler } from "@learn6502/core";
import { EventDispatcher } from "@learn6502/core";

export class Hexdump extends TextView implements HexdumpWidget {
readonly events = new EventDispatcher<HexdumpEventMap>();
Expand Down
4 changes: 2 additions & 2 deletions packages/app-android/app/widgets/game-console/display.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import {
CoreTypes,
} from "@nativescript/core";
import { isAndroid } from "@nativescript/core";
import type { Memory } from "@learn6502/6502";
import { DisplayAddressRange } from "@learn6502/6502";
import type { Memory } from "@learn6502/core";
import { DisplayAddressRange } from "@learn6502/core";
import { logger } from "~/utils";

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/app-android/app/widgets/game-console/gamepad.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { Button } from "@nativescript/core";
import { GridLayout, Builder } from "@nativescript/core";
import type { GamepadKey, GamepadEventMap, GamepadWidget } from "@learn6502/common-ui";
import { getGamepadKeyCode, getGamepadKeyChar } from "@learn6502/common-ui";
import { EventDispatcher } from "@learn6502/6502";
import { EventDispatcher } from "@learn6502/core";
import { logger } from "~/utils";

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/app-android/app/widgets/main-button.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { EventData } from "@nativescript/core";
import { Property, CSSType } from "@nativescript/core";
import { localize as _ } from "@nativescript/localize";
import type { SimulatorState } from "@learn6502/6502"; // Import shared simulator state
import type { SimulatorState } from "@learn6502/core"; // Import shared simulator state
import { Fab } from "./fab"; // Import the base Fab class
import {
MainButtonState,
Expand Down
2 changes: 1 addition & 1 deletion packages/app-android/app/widgets/source-view.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { TextView, Button } from "@nativescript/core";
import { ContentView, Property, Builder, booleanConverter, Color } from "@nativescript/core";
import { debounce, EventDispatcher } from "@learn6502/6502";
import { debounce, EventDispatcher } from "@learn6502/core";
import type { SourceViewEventMap, SourceViewWidget } from "@learn6502/common-ui";
import { OPCODE_PATTERN, COMMENT_PATTERN, HEX_VALUE_PATTERN } from "@learn6502/common-ui";
import { logger } from "~/utils";
Expand Down
2 changes: 1 addition & 1 deletion packages/app-android/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"check": "gjsify tsc --noEmit"
},
"dependencies": {
"@learn6502/6502": "^0.7.0",
"@learn6502/core": "^0.7.0",
"@learn6502/common-ui": "^0.7.0",
"@nativescript/core": "~9.0.20",
"@nativescript/localize": "^5.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ The application depends on several GNOME libraries and internal packages:

- GNOME libraries (GJS, GTK, Adwaita, etc.)
- Internal packages:
- `@learn6502/6502`: 6502 simulator and assembler
- `@learn6502/core`: 6502 simulator and assembler
- `@learn6502/learn`: Tutorial content
- `@learn6502/translations`: Localization support

Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
"@girs/pango-1.0": "1.57.1-4.0.4",
"@girs/webkit-6.0": "2.52.1-4.0.4",
"@gjsify/storybook": "^0.10.0",
"@learn6502/6502": "^0.7.0",
"@learn6502/core": "^0.7.0",
"@learn6502/common-ui": "^0.7.0",
"@learn6502/learn": "^0.7.0",
"@learn6502/translations": "^0.7.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/views/main.window.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Gdk from "@girs/gdk-4.0";
import Gio from "@girs/gio-2.0";
import GLib from "@girs/glib-2.0";

import { SimulatorState, num2hex, debounce } from "@learn6502/6502";
import { SimulatorState, num2hex, debounce } from "@learn6502/core";

import type { Learn, Editor, GameConsole, Debugger } from "./main";
import { HelpWindow } from "./help.window.ts";
Expand Down
4 changes: 2 additions & 2 deletions packages/app-gnome/src/views/main/debugger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import type { HexMonitor, Hexdump, Disassembled } from "../../widgets/debugger/i

import Template from "./debugger.blp";

import type { Assembler } from "@learn6502/6502";
import { type Memory, type Simulator } from "@learn6502/6502";
import type { Assembler } from "@learn6502/core";
import { type Memory, type Simulator } from "@learn6502/core";
import {
type DebuggerView,
type MessageConsoleWidget,
Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/views/main/editor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type Gtk from "@girs/gtk-4.0";
import type GtkSource from "@girs/gtksource-5";
import type { SourceView } from "../../widgets/source-view.ts";
import type { QuickHelpView } from "../../mdx/quick-help-view.ts";
import { EventDispatcher } from "@learn6502/6502";
import { EventDispatcher } from "@learn6502/core";
import type { EditorView, EditorEventMap } from "@learn6502/common-ui";
import { editorController } from "@learn6502/common-ui";

Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/views/main/game-console.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import GObject from "@girs/gobject-2.0";
import Adw from "@girs/adw-1";

import type { Memory, Labels, Simulator, Assembler } from "@learn6502/6502";
import type { Memory, Labels, Simulator, Assembler } from "@learn6502/core";

import type { Display, Gamepad } from "../../widgets/game-console/index.ts";
import {
Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/widgets/debugger/debug-info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import GObject from "@girs/gobject-2.0";
import Adw from "@girs/adw-1";
import type Gtk from "@girs/gtk-4.0";

import { type Simulator, num2hex, addr2hex } from "@learn6502/6502";
import { type Simulator, num2hex, addr2hex } from "@learn6502/core";
import { type DebugInfoWidget } from "@learn6502/common-ui";
import Template from "./debug-info.blp";

Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/widgets/debugger/disassembled.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import GObject from "@girs/gobject-2.0";
import Adw from "@girs/adw-1";
import type { SourceView } from "../source-view.ts";

import { type Assembler, EventDispatcher } from "@learn6502/6502";
import { type Assembler, EventDispatcher } from "@learn6502/core";
import type { DisassembledEventMap, DisassembledWidget, SourceViewCopyEvent } from "@learn6502/common-ui";

import Template from "./disassembled.blp";
Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/widgets/debugger/hex-monitor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Adw from "@girs/adw-1";
import type Gtk from "@girs/gtk-4.0";
import type { SourceView } from "../source-view.ts";

import { EventDispatcher, type Memory } from "@learn6502/6502";
import { EventDispatcher, type Memory } from "@learn6502/core";
import {
type HexMonitorOptions,
type HexMonitorWidget,
Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/widgets/debugger/hexdump.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import GObject from "@girs/gobject-2.0";
import Adw from "@girs/adw-1";
import type { SourceView } from "../source-view.ts";

import { type Assembler, EventDispatcher } from "@learn6502/6502";
import { type Assembler, EventDispatcher } from "@learn6502/core";
import { type HexdumpWidget, type HexdumpEventMap, type SourceViewCopyEvent } from "@learn6502/common-ui";

import Template from "./hexdump.blp";
Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/widgets/example-list-item.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import GObject from "@girs/gobject-2.0";
import Gtk from "@girs/gtk-4.0";

import type { ExampleMeta } from "@learn6502/examples";
import { Memory, DisplayAddressRange } from "@learn6502/6502";
import { Memory, DisplayAddressRange } from "@learn6502/core";
import type { SourceView } from "./source-view.ts";
import type { Display } from "./game-console/display.ts";

Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/widgets/game-console/display.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import { type DisplayWidget, gameConsoleStateService } from "@learn6502/common-ui";
import { DEFAULT_DISPLAY_CONFIG } from "@learn6502/common-ui/src/data/display-constants";
import { type Memory, DisplayAddressRange } from "@learn6502/6502";
import { type Memory, DisplayAddressRange } from "@learn6502/core";

export class Display extends Adw.Bin implements DisplayWidget {
// Child widgets
Expand Down Expand Up @@ -160,13 +160,13 @@
return this.grab_focus();
}

private drawClear(_drawingArea: Gtk.DrawingArea, cr: cairo.Context, width: number, height: number) {

Check warning on line 163 in packages/app-gnome/src/widgets/game-console/display.ts

View workflow job for this annotation

GitHub Actions / Code Quality

eslint(no-unused-vars)

Parameter 'height' is declared but never used. Unused parameters should start with a '_'.

Check warning on line 163 in packages/app-gnome/src/widgets/game-console/display.ts

View workflow job for this annotation

GitHub Actions / Code Quality

eslint(no-unused-vars)

Parameter 'width' is declared but never used. Unused parameters should start with a '_'.
const black = { red: 0, green: 0, blue: 0 };
cr.setSourceRGB(black.red, black.green, black.blue); // Set color to black
cr.paint(); // Paint the entire drawing area with the color above
}

private drawPixels(_drawingArea: Gtk.DrawingArea, cr: cairo.Context, width: number, height: number) {

Check warning on line 169 in packages/app-gnome/src/widgets/game-console/display.ts

View workflow job for this annotation

GitHub Actions / Code Quality

eslint(no-unused-vars)

Parameter 'height' is declared but never used. Unused parameters should start with a '_'.

Check warning on line 169 in packages/app-gnome/src/widgets/game-console/display.ts

View workflow job for this annotation

GitHub Actions / Code Quality

eslint(no-unused-vars)

Parameter 'width' is declared but never used. Unused parameters should start with a '_'.
if (!this.memory) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/widgets/game-console/gamepad.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Gtk from "@girs/gtk-4.0";
import { type GamepadKey, type GamepadWidget, type GamepadEventMap, getGamepadKeyCode } from "@learn6502/common-ui";

import Template from "./gamepad.blp";
import { EventDispatcher } from "@learn6502/6502";
import { EventDispatcher } from "@learn6502/core";

export class Gamepad extends Adw.Bin implements GamepadWidget {
readonly events: EventDispatcher<GamepadEventMap> = new EventDispatcher<GamepadEventMap>();
Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/widgets/main-button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import GObject from "@girs/gobject-2.0";
import Adw from "@girs/adw-1";
import type Gtk from "@girs/gtk-4.0";

import type { SimulatorState } from "@learn6502/6502";
import type { SimulatorState } from "@learn6502/core";
import {
MainButtonState,
type MainButtonMode,
Expand Down
4 changes: 2 additions & 2 deletions packages/app-gnome/src/widgets/share-dialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import Gdk from "@girs/gdk-4.0";
import GLib from "@girs/glib-2.0";

import type { ExampleMeta } from "@learn6502/examples";
import type { Memory } from "@learn6502/6502";
import { DisplayAddressRange } from "@learn6502/6502";
import type { Memory } from "@learn6502/core";
import { DisplayAddressRange } from "@learn6502/core";
import type { ExampleListItem } from "./example-list-item.ts";
import { copyToClipboard } from "../utils.ts";

Expand Down
2 changes: 1 addition & 1 deletion packages/app-gnome/src/widgets/source-view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import Template from "./source-view.blp";
import { GutterRendererLineNumbers } from "../gutter-renderer-line-numbers.ts";
import { GutterRendererMode } from "../types/index.ts";
import type { SourceViewWidget, SourceViewEventMap } from "@learn6502/common-ui";
import { EventDispatcher } from "@learn6502/6502";
import { EventDispatcher } from "@learn6502/core";

GtkSource.init();

Expand Down
2 changes: 1 addition & 1 deletion packages/app-web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"vite": "^8.0.16"
},
"dependencies": {
"@learn6502/6502": "^0.7.0"
"@learn6502/core": "^0.7.0"
}
}
Loading
Loading