Rename @learn6502/6502 to @learn6502/core for npm publishing#153
Merged
Conversation
npm's registry rejects publishing a purely-numeric scoped package name
("6502") with E400 "That word is not allowed", even though the client
validator accepts it. Rename the published core package to @learn6502/core
so it can be released to npm. The directory stays packages/6502/ and the
changeset fixed group (@learn6502/*) is unaffected.
theme.service.ts reached into the sibling package's source by relative path (../../../6502/src/event-dispatcher) instead of importing from the package by name like every other consumer. That only resolved because a stale node_modules/@learn6502/6502 symlink lingered next to the renamed @learn6502/core; a fresh install (as in CI) has only core, so the path broke. Use the canonical @learn6502/core import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the published core package
@learn6502/6502→@learn6502/coreacross the monorepo (77 files: all imports, package.json names, workspace scripts, CI workflows, docs).Why
npm's registry rejects publishing a purely-numeric scoped package name (
6502) withE400 "That word is not allowed"— even though the client-sidevalidate-npm-package-nameaccepts digit-containing names, the server applies a stricter name policy. The package therefore can't be released to npm under the old name.@learn6502/coreis descriptive (it's the core 6502 assembler/simulator/disassembler) and publishable.Notes
packages/6502/— only the package name changed (itsrepository.directorystill points atpackages/6502).fixedgroup is a glob (@learn6502/*), so it's unaffected.gjsify-lock.json/gjsify-sources.jsonare unchanged — workspace packages aren't external deps, they're resolved by name via workspace symlinks (re-wired bygjsify install).gjsify install(lock unchanged),gjsify workspace @learn6502/core build✅,gjsify workspace @learn6502/common-ui check✅ (the cross-workspace consumer).