Repository navigation
Document backend-only Adapt targets - #50
Merged
nHackel merged 2 commits intoNov 4, 2026
Merged
Conversation
Adapt.adapt takes the backing array type of the target backend, such as Array, CuArray or ROCArray, without element-type parameters; the element type is chosen when the operator is constructed. Add a section to the GPU guide that contrasts the Adapt target with the parameterized storage type S, and state the same in the GradientOp docstring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 81.23% 81.23%
=======================================
Files 15 15
Lines 613 613
=======================================
Hits 498 498
Misses 115 115 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nHackel
approved these changes
Nov 4, 2026
nHackel
left a comment
nHackel
left a comment
Member
There was a problem hiding this comment.
I like the howto GPU note on adaption. I think once everything is settled, you can do a last clean up pass and instead of each operator repeating what you essentially says there we can either just attach it to the specific adapt doc string or make a very small mention in the constructor.
Or even just a small list in the howto docs
I'll merge this for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #49 (#49 (comment)),
Adapt.adaptshould be given the backing array type of the target backend, such asArray,CuArrayorROCArray, without element-type parameters. The element type is chosen when the operator is constructed.S(CuArray{T, 1}), and gives a short GradientOp example in a non-executed code block.GradientOpdocstring.Documentation only. No code or test changes.
julia --project=docs docs/make.jlbuilds locally.