Repository navigation
Conversation
Keep the shared Adapt target rules in the GPU how-to, add the list of operators that implement Adapt, and point the operator docstrings to it. The GradientOp docstring no longer repeats the shared rules; the docstrings keep only their operator-specific behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 82.06% 84.01% +1.94%
==========================================
Files 15 16 +1
Lines 630 713 +83
==========================================
+ Hits 517 599 +82
- Misses 113 114 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review of #50 (#50 (review)): the shared Adapt target rules now live only in the GPU how-to, instead of being repeated per operator.
GradientOpdocstring no longer repeats the shared target rules and keeps only its operator-specific behaviour.GradientOp,SamplingOp,RadonOp,FFTOp,NFFTOp,NFFTToeplitzNormalOpandRowBlockOppoint to that section.Documentation only. No code or test changes.
julia --project=docs docs/make.jlbuilds locally.