Add Mock Integration Test Coverage for CustomizeCTA Component#8090
Add Mock Integration Test Coverage for CustomizeCTA Component#8090Shikhartiwari967 wants to merge 3 commits into
Conversation
|
@Shikhartiwari967 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR introduces a new test suite for the CustomizeCTA component, which enhances our testing coverage by mocking various integrations. This approach is similar to previous decisions made for other components, such as the SuccessGuide and CommitPulseSection, where we emphasized the importance of testing under different scenarios without relying on real network calls. It's great to see this focus on robust testing practices! Looking forward to your feedback. |
|
Hi @Aamod007 Sir, The new CustomizeCTA.mock-integrations.test.tsx test suite passes locally and the component-specific tests complete successfully. The current CI failure appears to originate from existing repository-wide TypeScript issues in: app/generator/components/EditorPanel.type-compiler.test.tsx These files are outside the scope of this PR, which only adds mock integration test coverage for CustomizeCTA. Please let me know if any changes are required from my side. Thank you! |
Aamod007
left a comment
There was a problem hiding this comment.
Great job adding mock integration tests for the CustomizeCTA component. However, this PR is blocked by a failing CI check. Please resolve the issues and rerun the CI pipeline.
|
Hi @Aamod007 sir , please review and merge it. |
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
Aamod007
left a comment
There was a problem hiding this comment.
Solid test suite. The mocks are well put together, and using \�i.fn()\ to spy on translation keys is good practice. LGTM!
Description
Fixes #6826
Added a dedicated test suite for
CustomizeCTAto verify asynchronous service layer mocking and integration behavior.Changes
CustomizeCTA.mock-integrations.test.tsxPillar
Visual Preview
N/A (Test-only changes)
Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run lintlocally.README.mdif required (not applicable).Notes
Repository-wide typecheck failures, if any, originate from unrelated existing files outside the scope of this PR.