Skip to content

Enhance ContributorsClient with Error Resilience Tests#8098

Open
Shikhartiwari967 wants to merge 3 commits into
JhaSourav07:mainfrom
Shikhartiwari967:test-contributorsclient-error-resilience
Open

Enhance ContributorsClient with Error Resilience Tests#8098
Shikhartiwari967 wants to merge 3 commits into
JhaSourav07:mainfrom
Shikhartiwari967:test-contributorsclient-error-resilience

Conversation

@Shikhartiwari967

Copy link
Copy Markdown
Contributor

Description

Fixes #6853

Changes

  • Added ContributorsClient.error-resilience.test.tsx
  • Verified rendering with valid contributor data
  • Verified rendering with empty contributor data
  • Verified Leaderboard renders correctly
  • Verified ContributorsSearch renders correctly
  • Verified Footer renders without runtime errors
  • Added five isolated Vitest test cases

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Testing)

Visual Preview

N/A (Test-only changes)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm run lint locally.
  • My commit follows the Conventional Commits format.
  • I have updated README.md if required (not applicable).
  • I have starred the repository.
  • I have made sure I have only one commit in this PR.
  • This PR only adds automated test coverage.

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@Shikhartiwari967 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@retenta-bot

retenta-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

This pull request introduces important error resilience tests for the ContributorsClient component, which is a great step towards improving the stability of our application. It aligns well with our previous decision to implement similar tests for the ContributorsSearch component, ensuring that we maintain a robust user experience even in the face of errors. Thank you for your contributions, and I look forward to your updates!

@retenta-bot retenta-bot Bot changed the title Test contributorsclient error resilience Enhance ContributorsClient with Error Resilience Tests Jul 15, 2026
@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jul 15, 2026
@Shikhartiwari967

Copy link
Copy Markdown
Contributor Author

Hi @Aamod007 Sir,

I verified this test locally:

✅ npm test -- ContributorsClient.error-resilience.test.tsx passes (5/5 tests)
✅ ESLint passes for the new test file.

The CI failure appears to come from existing TypeScript errors in:

app/generator/components/EditorPanel.type-compiler.test.tsx
app/generator/components/PreviewPanel.type-compiler.test.tsx

These files are unrelated to the changes in this PR.

@Shikhartiwari967

Copy link
Copy Markdown
Contributor Author

Hi @Aamod007 sir, review it.

@Aamod007 Aamod007 added level:intermediate Moderate complexity tasks quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests mentor:Aamod007 labels Jul 17, 2026

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work adding the error resilience and mock integration tests for the ContributorsClient and CustomizeCTA components. However, this PR is currently blocked due to a failing CI check. Please resolve the issues and rerun the CI pipeline.

@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3958.92 KB 3958.92 KB 0 B
Total CSS 327.67 KB 327.67 KB 0 B

@Shikhartiwari967

Copy link
Copy Markdown
Contributor Author

Hi @Aamod007 sir, please review and merge it.

@Aamod007 Aamod007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mocks and error resilience tests in \ContributorsClient.error-resilience.test.tsx\ look great. However, this PR contains a duplicate file from PR #8090 (\CustomizeCTA.mock-integrations.test.tsx). Please rebase your branch onto \main\ so that this PR only contains your new tests for \ContributorsClient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ContributorsClient-error-resilience): verify Hydration Stability, Exception Safety & Error Fallbacks (Variation 6)

2 participants