Enhance ContributorsClient with Error Resilience Tests#8098
Enhance ContributorsClient with Error Resilience Tests#8098Shikhartiwari967 wants to merge 3 commits into
Conversation
|
@Shikhartiwari967 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request introduces important error resilience tests for the ContributorsClient component, which is a great step towards improving the stability of our application. It aligns well with our previous decision to implement similar tests for the ContributorsSearch component, ensuring that we maintain a robust user experience even in the face of errors. Thank you for your contributions, and I look forward to your updates! |
|
Hi @Aamod007 Sir, I verified this test locally: ✅ npm test -- ContributorsClient.error-resilience.test.tsx passes (5/5 tests) The CI failure appears to come from existing TypeScript errors in: app/generator/components/EditorPanel.type-compiler.test.tsx These files are unrelated to the changes in this PR. |
|
Hi @Aamod007 sir, review it. |
Aamod007
left a comment
There was a problem hiding this comment.
Nice work adding the error resilience and mock integration tests for the ContributorsClient and CustomizeCTA components. However, this PR is currently blocked due to a failing CI check. Please resolve the issues and rerun the CI pipeline.
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
|
Hi @Aamod007 sir, please review and merge it. |
Aamod007
left a comment
There was a problem hiding this comment.
The mocks and error resilience tests in \ContributorsClient.error-resilience.test.tsx\ look great. However, this PR contains a duplicate file from PR #8090 (\CustomizeCTA.mock-integrations.test.tsx). Please rebase your branch onto \main\ so that this PR only contains your new tests for \ContributorsClient.
Description
Fixes #6853
Changes
ContributorsClient.error-resilience.test.tsxPillar
Visual Preview
N/A (Test-only changes)
Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run lintlocally.README.mdif required (not applicable).