Skip to content

CI is the pull-request gate, and the nightly builds what merged #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hawkynt merged 1 commit into from
Aug 29, 2026
Merged

CI is the pull-request gate, and the nightly builds what merged #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,17 @@ name: CI
# Event-driven (no cron). Replaces the old NewBuild.yml + Tests.yml.
# release.yml and nightly.yml reuse this via `workflow_call` / `workflow_run`.
on:
push:
branches: [main]
pull_request:
branches: [main]
workflow_call: {}
workflow_dispatch: {}

# Pushing three times to a branch used to queue three full matrices and run all of them. A newer
# pull-request run supersedes the older one; a push to main is not cancelled, because main wants a
# recorded result for every commit rather than only for the newest.
concurrency:
group: ci-${{ github.event_name }}-${{ github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

# Force JavaScript-based actions to run on Node 24 instead of the deprecated Node 20 ahead of
# the 2026-06-16 hard cutover, until we bump each action to a Node-24-native major version.
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ name: Nightly
# After CI succeeds on main, publish a dated prerelease with the packed
# packages, then prune old nightlies on a GFS schedule. Does NOT push to NuGet.
on:
workflow_run:
workflows: [CI]
push:
branches: [main]
types: [completed]
workflow_dispatch: {}

# Force JavaScript-based actions to run on Node 24 instead of the deprecated Node 20 ahead of
Expand All @@ -16,7 +14,6 @@ env:

jobs:
nightly:
if: ${{ github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success' }}
runs-on: ubuntu-latest
permissions:
contents: write
Expand Down Expand Up @@ -63,7 +60,7 @@ jobs:
with:
tag_name: ${{ env.NIGHTLY_TAG }}
name: ${{ env.NIGHTLY_TAG }}
target_commitish: ${{ github.event.workflow_run.head_sha || github.sha }}
target_commitish: ${{ github.sha }}
prerelease: true
files: artifacts/*.nupkg
body_path: RELEASE_NOTES.md # commit-message changelog, not GitHub's PR notes
Expand Down
Loading