Repository navigation
CI is the pull-request gate, and the nightly builds what merged - #18
Merged
Merged
Conversation
CI no longer runs on a push to main. A pull request has to be green to merge, so re-running the same matrix on the merge commit proves nothing and costs a machine. nightly.yml moves from 'workflow_run: CI completed' to 'push: main' and builds what just landed rather than testing it again — the old chain would never have fired again anyway. Named rather than hidden: a squash merge produces a commit no run ever saw, so a semantic conflict between two separately green pull requests first surfaces as a failed nightly build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI no longer runs on a push to
main. A pull request has to be green to merge, so re-running the same matrix on the merge commit proves nothing a green pull request has not already proved — and it was costing a machine every time.ci.ymltriggers onpull_requestonly.workflow_callstays, becauserelease.ymlruns it as its own first gate;workflow_dispatchis there for when you want it by hand.nightly.ymlmoves fromworkflow_run: CI completedtopush: main, and builds what just landed rather than testing it again. The old chain would never have fired again anyway, since CI no longer runs on main.The trade-off, stated plainly: a squash merge produces a commit no run ever saw — the pull request's tree on a base that may have moved. A semantic conflict between two separately green pull requests would first surface as a failed nightly build rather than a failed CI run.
Canonical in
RepositoryTemplate; every C# repo gets the same shape.