Conversation
sararob
marked this pull request as draft
September 22, 2026 14:32
There was a problem hiding this comment.
Code Review
This pull request introduces a sample healthcare application demonstrating how to build SQL, semantic search, and secure database agents using the Agent Development Kit (ADK) and Cloud Spanner. It includes setup scripts, database schemas, and three distinct agent implementations. The review feedback highlights a critical need to validate the GOOGLE_CLOUD_PROJECT environment variable across all agents to prevent runtime failures when it is missing. Additionally, in the semantic agent, it is recommended to instantiate the GenAI Client at the module level rather than on every function call to avoid unnecessary overhead.
sararob
marked this pull request as ready for review
September 22, 2026 15:36
Lsubatin
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a sample showing how to use the ADK's Spanner integration. The sample includes 3 agents: