[derrickaw]

1. add kafkaToBigtable blueprint IT etc
2. remove not supported parameters from kafka_options and other blueprints until supported

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.08%. Comparing base (5663e39) to head (5dd9b6d).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #4363      +/-   ##
============================================
+ Coverage     33.89%   38.08%   +4.19%     
- Complexity      505      517      +12     
============================================
  Files           215      195      -20     
  Lines         13186    11853    -1333     
  Branches       1320     1209     -111     
============================================
+ Hits           4469     4514      +45     
+ Misses         8350     6968    -1382     
- Partials        367      371       +4     

Components	Coverage Δ
spanner-templates	∅ <ø> (∅)
spanner-import-export	∅ <ø> (∅)
spanner-live-forward-migration	∅ <ø> (∅)
spanner-live-reverse-replication	∅ <ø> (∅)
spanner-bulk-migration	∅ <ø> (∅)
gcs-spanner-dv	∅ <ø> (∅)
see 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Kafka to Bigtable YAML template for Dataflow, facilitating seamless streaming data ingestion. It also performs a cleanup of existing Kafka-based templates by removing several unsupported configuration parameters, ensuring a more stable and consistent configuration interface across the template suite.

Highlights

• New Template: Added a new Kafka to Bigtable YAML template to support streaming data ingestion from Kafka to Bigtable.
• Integration Testing: Implemented comprehensive integration tests for the new Kafka to Bigtable template.
• Parameter Cleanup: Removed unsupported Kafka configuration parameters (allowDuplicates, offsetDeduplication, redistributeByRecordKey, redistributeNumKeys, redistributed) from existing BigQuery and Iceberg templates.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces the new Kafka to Bigtable (YAML) template, which includes its Java interface, YAML pipeline definition, documentation, and integration tests. Additionally, it cleans up several unused parameters (such as allowDuplicates and redistribution options) from existing Kafka-to-Iceberg and Kafka-to-BigQuery YAML templates. The review feedback highlights several improvement opportunities: managing the KafkaProducer in the integration test with a try-with-resources block to avoid resource leaks, correcting the YAML list syntax for requirements in KafkaToBigtable.yaml, and providing realistic examples instead of empty strings for the language and fields template parameters.

[damccorm]

Generally this LGTM. I did have one open question

[damccorm]

Actually, found a few more potential issues with Jetski, I'll add those too.

[damccorm]

Thanks